len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-11-09 13:12:37 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

rbutil: HttpGet: Return NetworkError in done signal.

Browse source 
Return the status value instead of simply a bool.

Change-Id: I2bffaac0087418656e80c74dc352011a4ea32ab1
This commit is contained in:
Dominik Riebeling 2022-03-16 22:19:00 +01:00
parent 08b42791ff
commit a0459de4d5
13 changed files with 35 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

13
utils/rbutilqt/themesinstallwindow.cpp
View file

@ -100,7 +100,7 @@ void ThemesInstallWindow::downloadInfo()
}
void ThemesInstallWindow::downloadDone(bool error)
void ThemesInstallWindow::downloadDone(QNetworkReply::NetworkError error)
{
LOG_INFO() << "Download done, error:" << error;
@ -116,7 +116,7 @@ void ThemesInstallWindow::downloadDone(bool error)
<< iniDetails.value("error/description").toString()
<< iniDetails.value("error/query").toString();
if(error) {
if(error != QNetworkReply::NoError) {
logger->addItem(tr("Network error: %1.\n"
"Please check your network and proxy settings.")
.arg(getter->errorString()), LOGERROR);
@ -236,19 +236,18 @@ void ThemesInstallWindow::updateDetails(QListWidgetItem* cur, QListWidgetItem* p
}
void ThemesInstallWindow::updateImage(bool error)
void ThemesInstallWindow::updateImage(QNetworkReply::NetworkError error)
{
LOG_INFO() << "Updating image:"<< !error;
if(error) {
if(error != QNetworkReply::NoError) {
ui.themePreview->clear();
ui.themePreview->setText(tr("Retrieving theme preview failed.\n"
"HTTP response code: %1").arg(igetter.httpResponse()));
return;
}
QPixmap p;
if(!error) {
else {
QPixmap p;
imgData = igetter.readAll();
if(imgData.isNull()) return;
p.loadFromData(imgData);