len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-10-14 02:27:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Open Plugin cleanup

Browse source 
cleanup a few unneded functions

Change-Id: I7207fd1380f92bb26ab8365a4bbef6104975acbe
This commit is contained in:
William Wilgus 2020-08-17 21:59:43 -04:00 • committed by William Wilgus
parent f029078f0d
commit 96e1bb6556
2 changed files with 1 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

25
apps/open_plugin.c
View file

@ -24,7 +24,6 @@
#include "plugin.h" #include "plugin.h"
#include "open_plugin.h" #include "open_plugin.h"
#include "pathfuncs.h" #include "pathfuncs.h"
#include "keyboard.h"
#include "splash.h" #include "splash.h"
#include "lang.h" #include "lang.h"
@ -32,14 +31,6 @@ struct open_plugin_entry_t open_plugin_entry;
static const int op_entry_sz = sizeof(struct open_plugin_entry_t); static const int op_entry_sz = sizeof(struct open_plugin_entry_t);
static void get_param(void)
{
char tmp_buf[OPEN_PLUGIN_BUFSZ+1];
strlcpy(tmp_buf, open_plugin_entry.param, OPEN_PLUGIN_BUFSZ);
if (kbd_input(tmp_buf, OPEN_PLUGIN_BUFSZ, NULL))
strlcpy(open_plugin_entry.param, tmp_buf, OPEN_PLUGIN_BUFSZ);
}
uint32_t open_plugin_add_path(const char *key, const char *plugin, const char *parameter) uint32_t open_plugin_add_path(const char *key, const char *plugin, const char *parameter)
{ {
int len; int len;
@ -72,15 +63,7 @@ uint32_t open_plugin_add_path(const char *key, const char *plugin, const char *p
strlcpy(open_plugin_entry.path, plugin, OPEN_PLUGIN_BUFSZ); strlcpy(open_plugin_entry.path, plugin, OPEN_PLUGIN_BUFSZ);
if(parameter) if(parameter)
{
if (parameter[0] == '\0' &&
yesno_pop(ID2P(LANG_PARAMETER)))
{
get_param();
}
else
strlcpy(open_plugin_entry.param, parameter, OPEN_PLUGIN_BUFSZ); strlcpy(open_plugin_entry.param, parameter, OPEN_PLUGIN_BUFSZ);
}
write(fd, &open_plugin_entry, op_entry_sz); write(fd, &open_plugin_entry, op_entry_sz);
} }
@ -131,15 +114,7 @@ void open_plugin_browse(const char *key)
browse.bufsize = OPEN_PLUGIN_BUFSZ; browse.bufsize = OPEN_PLUGIN_BUFSZ;
if (rockbox_browse(&browse) == GO_TO_PREVIOUS) if (rockbox_browse(&browse) == GO_TO_PREVIOUS)
{
open_plugin_add_path(key, tmp_buf, NULL); open_plugin_add_path(key, tmp_buf, NULL);
}
}
void open_plugin_remove(const char *key)
{
(void)key;
open_plugin_add_path(key, NULL, NULL);
} }
static int open_plugin_hash_get_entry(uint32_t hash, struct open_plugin_entry_t *entry) static int open_plugin_hash_get_entry(uint32_t hash, struct open_plugin_entry_t *entry)

1
apps/open_plugin.h
View file

@ -58,7 +58,6 @@ extern struct open_plugin_entry_t open_plugin_entry;
uint32_t open_plugin_add_path(const char *key, const char *plugin, const char *parameter); uint32_t open_plugin_add_path(const char *key, const char *plugin, const char *parameter);
int open_plugin_get_entry(const char *key, struct open_plugin_entry_t *entry); int open_plugin_get_entry(const char *key, struct open_plugin_entry_t *entry);
void open_plugin_browse(const char *key); void open_plugin_browse(const char *key);
void open_plugin_remove(const char *key);
int open_plugin_run(const char *key); int open_plugin_run(const char *key);
#endif #endif