From 9101f3551965245662b89a9e54742282d52f8f11 Mon Sep 17 00:00:00 2001 From: Solomon Peachy Date: Wed, 23 Sep 2026 16:48:29 -0400 Subject: [PATCH] ROLO: Get rid of redundant call to audio_hard_stop() audio_hard_stop() should be called *prior* to rolo_load(), and indeed already is at every call site. The reason to remove it from inside rolo_load() as opposed to the call sites is because those already show a feedback splash while the audio path is being shut down. Change-Id: Ib6b995f7172c6a92599ace75245909730b2e941a --- firmware/rolo.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/firmware/rolo.c b/firmware/rolo.c index d832496270..0210cfe78c 100644 --- a/firmware/rolo.c +++ b/firmware/rolo.c @@ -28,7 +28,6 @@ #include "kernel.h" #include "button.h" #include "file.h" -#include "audio.h" #include "system.h" #include "i2c.h" #include "adc.h" @@ -219,6 +218,7 @@ extern unsigned long loadaddress; * Name: rolo_load(const char *filename) * Filename must be a fully defined filename including the path and extension * + * Must call audio_hard_stop() before calling us! ***************************************************************************/ int rolo_load(const char* filename) { @@ -238,8 +238,6 @@ int rolo_load(const char* filename) lcd_remote_update(); #endif - audio_hard_stop(); - /* get the system buffer. release only in case of error, otherwise * we don't return anyway */ rolo_handle = core_alloc_maximum(&filebuf_size, &buflib_ops_locked);