len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-10-13 18:17:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

checkwps: Warn if using SYSFONT in a viewport

Browse source 
Change-Id: Ief69dd489d08af62ed96624dfe504ab5b9f9e6d9
This commit is contained in:
Solomon Peachy 2025-03-07 09:39:53 -05:00
parent a05bd377ab
commit 8ef4f217d4
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
apps/gui/skin_engine/skin_parser.c
View file

@ -1071,11 +1071,7 @@ static int parse_progressbar_tag(struct skin_element* element,
pb->height = -1; /* calculate at display time */ pb->height = -1; /* calculate at display time */
else else
{ {
#ifndef __PCTOOL__
pb->height = font_get(vp->font)->height; pb->height = font_get(vp->font)->height;
#else
pb->height = 8;
#endif
} }
} }
/* optional params, first is the image filename if it isnt recognised as a keyword */ /* optional params, first is the image filename if it isnt recognised as a keyword */
@ -2164,6 +2160,10 @@ static bool skin_load_fonts(struct wps_data *data)
else if (font_id <= 0) else if (font_id <= 0)
{ {
vp->font = FONT_SYSFIXED; vp->font = FONT_SYSFIXED;
DEBUGF("WARNING: Do not use SYSFONT (id 0) in viewports!\n");
#ifdef __PCTOOL__
// success = false;
#endif
continue; continue;
} }
@ -2190,7 +2190,7 @@ static bool skin_load_fonts(struct wps_data *data)
font->id = font_load_ex(path, 0, skinfonts[font_id-2].glyphs); font->id = font_load_ex(path, 0, skinfonts[font_id-2].glyphs);
#else #else
font->id = font_load(path); font->id = font_load(path);
#endif #endif
//printf("[%d] %s -> %d\n",font_id, font->name, font->id); //printf("[%d] %s -> %d\n",font_id, font->name, font->id);
id_array[font_count++] = font->id; id_array[font_count++] = font->id;