From 8d15aff38ac5649c48bebda94693c03ca0627772 Mon Sep 17 00:00:00 2001 From: Solomon Peachy Date: Sun, 18 Jan 2026 07:44:48 -0500 Subject: [PATCH] devinput: Fix regression on Hiby R1 3a4da9381eccf62 change an underdocumented definition that turns out to be important, yet not documented in the linux uapi definitions. Revert that change, and document the magic values so this doesn't happen again. Change-Id: I0fac4a9d68170920bb5db1018d765e8a2994a95f --- firmware/target/hosted/button-devinput.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/firmware/target/hosted/button-devinput.c b/firmware/target/hosted/button-devinput.c index 343f1a4fe8..a9129f3ea6 100644 --- a/firmware/target/hosted/button-devinput.c +++ b/firmware/target/hosted/button-devinput.c @@ -105,9 +105,10 @@ static enum TOUCHSCREEN_STATE_DOWN } _last_touch_state = TOUCHSCREEN_STATE_UNKNOWN; -// XXX ... figure out what is standard. +/* Do _NOT_ change this. Unofficial Linux API */ +#define EVENT_VALUE_TOUCHSCREEN_RELEASE -1 +/* This is only used as an arbitrary placeholder */ #define EVENT_VALUE_TOUCHSCREEN_PRESS 1 -#define EVENT_VALUE_TOUCHSCREEN_RELEASE 0 static int ts_enabled = 1;