len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2026-04-12 00:47:49 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

1st/2nd Gen: Backlight inversion needs to be protected from interrupts, because it can happen any time, even while the greyscale lib or something else is writing to the LCD from an ISR. Also make backlight inversion only hit the LCD if necessary. * Use register definition in the 1st..3rd Gen backlight drivers.

Browse source 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16962 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Jens Arnold 2008-04-04 17:33:39 +00:00
parent aa9dbfef19
commit 8399749412
3 changed files with 16 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

4
firmware/target/arm/ipod/1g2g/backlight-1g2g.c
View file

@ -23,12 +23,12 @@
void _backlight_on(void)
{
outl(inl(0xc0001000) | 0x02, 0xc0001000);
LCD1_CONTROL |= 0x02;
lcd_set_backlight_inversion(true);
}
void _backlight_off(void)
{
outl(inl(0xc0001000) & ~0x02, 0xc0001000);
LCD1_CONTROL &= ~0x02;
lcd_set_backlight_inversion(false);
}

4
firmware/target/arm/ipod/3g/backlight-3g.c
View file

@ -22,10 +22,10 @@
void _backlight_on(void)
{
outl(inl(0xc0001000) | 0x02, 0xc0001000);
LCD1_CONTROL |= 0x02;
}
void _backlight_off(void)
{
outl(inl(0xc0001000) & ~0x02, 0xc0001000);
LCD1_CONTROL &= ~0x02;
}

22
firmware/target/arm/ipod/lcd-gray.c
View file

@ -126,10 +126,9 @@ void lcd_init_device(void)
lcd_cmd_and_data(R_DRV_WAVEFORM_CONTROL, 0x48);
/* C waveform, no EOR, 9 lines inversion */
lcd_cmd_and_data(R_POWER_CONTROL, POWER_REG_H | 0xc);
lcd_cmd_and_data(R_DISPLAY_CONTROL, 0x0015);
#ifdef HAVE_BACKLIGHT_INVERSION
invert_display();
#else
lcd_cmd_and_data(R_DISPLAY_CONTROL, 0x0015);
#endif
lcd_set_flip(false);
lcd_cmd_and_data(R_ENTRY_MODE, 0x0000);
@ -162,10 +161,16 @@ void lcd_set_contrast(int val)
#ifdef HAVE_BACKLIGHT_INVERSION
static void invert_display(void)
{
if (lcd_inverted ^ lcd_backlit)
lcd_cmd_and_data(R_DISPLAY_CONTROL, 0x0017);
else
lcd_cmd_and_data(R_DISPLAY_CONTROL, 0x0015);
static bool last_invert = false;
bool new_invert = lcd_inverted ^ lcd_backlit;
if (new_invert != last_invert)
{
int oldlevel = disable_irq_save();
lcd_cmd_and_data(R_DISPLAY_CONTROL, new_invert? 0x0017 : 0x0015);
restore_irq(oldlevel);
last_invert = new_invert;
}
}
void lcd_set_invert_display(bool yesno)
@ -182,10 +187,7 @@ void lcd_set_backlight_inversion(bool yesno)
#else
void lcd_set_invert_display(bool yesno)
{
if (yesno)
lcd_cmd_and_data(R_DISPLAY_CONTROL, 0x0017);
else
lcd_cmd_and_data(R_DISPLAY_CONTROL, 0x0015);
lcd_cmd_and_data(R_DISPLAY_CONTROL, yesno ? 0x0017 : 0x0015);
}
#endif