len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-12-08 12:45:26 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Undo the hacks that allowed targets without LEFT/RIGHT (UP/DN) to build.

Browse source 
Replaced them with warnings until they are fixed *PROPERLY*

Change-Id: I4425200e60f8b5224262a54f105b974cec471d22
This commit is contained in:
Solomon Peachy 2020-10-08 18:27:03 -04:00
parent dc81f96fd1
commit 7a1bf01541
8 changed files with 31 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

4
firmware/target/arm/rk27xx/ihifi2/button-target.h
View file

@ -32,8 +32,8 @@
#define BUTTON_VOL_UP 0x00000020
#define BUTTON_VOL_DOWN 0x00000040
#define BUTTON_LEFT 0
#define BUTTON_RIGHT 0
#define BUTTON_LEFT BUTTON_PREV
#define BUTTON_RIGHT BUTTON_NEXT
#define BUTTON_MAIN (BUTTON_POWER | BUTTON_HOME | BUTTON_PREV | BUTTON_NEXT | \
BUTTON_PLAY | BUTTON_VOL_UP | BUTTON_VOL_DOWN)

4
firmware/target/arm/s5l8700/meizu-m3/button-target.h
View file

@ -28,10 +28,6 @@
#define BUTTON_MENU 0x00000002
#define BUTTON_PLAY 0x00000004
/* there are no LEFT/RIGHT buttons, but other parts of the code expect them */
#define BUTTON_LEFT 0
#define BUTTON_RIGHT 0
#define BUTTON_MAIN (BUTTON_PREVNEXT|BUTTON_MENU|BUTTON_PLAY)
#define POWEROFF_BUTTON BUTTON_PLAY

7
firmware/target/mips/ingenic_jz47xx/onda_vx767/button-target.h
View file

@ -32,11 +32,8 @@
#define BUTTON_REWIND 0x00000020
#define BUTTON_FAST_FWD 0x00000040
/* Compatibility hacks for flipping. Needs a somewhat better fix. */
#define BUTTON_LEFT 0
#define BUTTON_RIGHT 0
#define BUTTON_UP 0
#define BUTTON_DOWN 0
#define BUTTON_LEFT BUTTON_REWIND
#define BUTTON_RIGHT BUTTON_FAST_FWD
#define BUTTON_MAIN (BUTTON_SELECT | BUTTON_VOL_UP | BUTTON_VOL_DOWN | BUTTON_MENU \
BUTTON_MENU | BUTTON_BACK | BUTTON_REWIND | BUTTON_FAST_FWD)

5
firmware/target/mips/ingenic_jz47xx/xduoo_x3/button-target.h
View file

@ -33,12 +33,13 @@
#define BUTTON_VOL_UP 0x00000040
#define BUTTON_VOL_DOWN 0x00000080
#define BUTTON_PWRALT 0x00000100 /* BUTTON_POWER combo with other buttons */
#define BUTTON_LEFT 0
#define BUTTON_RIGHT 0
#define BUTTON_MAIN (BUTTON_POWER | BUTTON_HOME | BUTTON_OPTION | BUTTON_PREV | \
BUTTON_NEXT | BUTTON_PLAY | BUTTON_VOL_UP | BUTTON_VOL_DOWN)
#define BUTTON_LEFT BUTTON_PREV
#define BUTTON_RIGHT BUTTON_NEXT
/* Software power-off */
#define POWEROFF_BUTTON BUTTON_POWER
#define POWEROFF_COUNT 10