len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-10-13 18:17:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Don't try to set default_val in volume_limit_is_changed().

Browse source 
We don't use the default_val anywhere, so there's no need to try
to use it in a buggy and null pointer dereferencing way here.

Change-Id: Ie60dbab7647056e2bf457cb5dcc5b60012ea1651
This commit is contained in:
Frank Gevaerts 2014-01-13 15:26:13 +01:00
parent f0bec023d9
commit 72367f458e
1 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
apps/settings_list.c
View file

@ -675,10 +675,8 @@ static char* volume_limit_write_to_cfg(void* setting, char*buf, int buf_len)
}
static bool volume_limit_is_changed(void* setting, void* defaultval)
{
(void)defaultval;
int current = *(int*)setting;
if ((int*)defaultval == NULL)
*(int*)defaultval = sound_max(SOUND_VOLUME);
return (current != sound_max(SOUND_VOLUME));
}
static void volume_limit_set_default(void* setting, void* defaultval)