From 6d9c353f2e1ff4f1bc24130dca71aded053fcec3 Mon Sep 17 00:00:00 2001 From: Dave Chapman Date: Mon, 24 Mar 2008 10:13:47 +0000 Subject: [PATCH] Add another safety-check in the bitmap strips parsing - don't allow the num_subimages parameter to %xl to be <= 0 git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16779 a1c6a512-1295-4272-9138-f99709370657 --- apps/gui/wps_parser.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/apps/gui/wps_parser.c b/apps/gui/wps_parser.c index 9327e89859..940b3e45ed 100644 --- a/apps/gui/wps_parser.c +++ b/apps/gui/wps_parser.c @@ -516,6 +516,9 @@ static int parse_image_load(const char *wps_bufptr, pos = strchr(ptr, '|'); if (pos && pos < newline) wps_data->img[n].num_subimages = atoi(ptr); + + if (wps_data->img[n].num_subimages <= 0) + return WPS_ERROR_INVALID_PARAM; } /* Skip the rest of the line */