len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-10-14 10:37:38 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

bitmap drawing: use temp vars to help gcc opmize loops.

Browse source 
By saving current_vp fields into temp vars just before the loop gcc can
put them into registers. This yields ~15% speedup for drawing anti-aliased fonts.

Change-Id: I4c0c9f5ff7a7f084e2eb08c4ed874176b1f9832c
This commit is contained in:
Thomas Martitz 2013-02-08 23:41:51 +01:00
parent 1430b07894
commit 68d3ce2acd
1 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

20
firmware/drivers/lcd-16bit-common.c
View file

@ -853,12 +853,6 @@ static inline unsigned blend_two_colors(unsigned c1, unsigned c2, unsigned a)
#endif #endif
} }
/* Blend the given color with the value from the alpha_color_lookup table */
static inline unsigned blend_color(unsigned c, unsigned a)
{
return blend_two_colors(c, current_vp->fg_pattern, a);
}
/* Blend an image with an alpha channel /* Blend an image with an alpha channel
* if image is NULL, drawing will happen according to the drawmode * if image is NULL, drawing will happen according to the drawmode
* src is the alpha channel (4bit per pixel) */ * src is the alpha channel (4bit per pixel) */
@ -979,7 +973,10 @@ static void ICODE_ATTR lcd_alpha_bitmap_part_mix(const fb_data* image,
/* go through the rows and update each pixel */ /* go through the rows and update each pixel */
do do
{ {
unsigned bg; /* saving current_vp->fg/bg_pattern and lcd_backdrop_offset into these
* temp vars just before the loop helps gcc to opimize the loop better
* (testing showed ~15% speedup) */
unsigned fg, bg;
uintptr_t bo; uintptr_t bo;
col = width; col = width;
dst = dst_row; dst = dst_row;
@ -1053,9 +1050,10 @@ static void ICODE_ATTR lcd_alpha_bitmap_part_mix(const fb_data* image,
while (--col); while (--col);
break; break;
case DRMODE_FG: case DRMODE_FG:
fg = current_vp->fg_pattern;
do do
{ {
*dst = blend_color(*dst, data & ALPHA_COLOR_LOOKUP_SIZE ); *dst = blend_two_colors(*dst, fg, data & ALPHA_COLOR_LOOKUP_SIZE );
dst += COL_INC; dst += COL_INC;
UPDATE_SRC_ALPHA; UPDATE_SRC_ALPHA;
} }
@ -1063,10 +1061,11 @@ static void ICODE_ATTR lcd_alpha_bitmap_part_mix(const fb_data* image,
break; break;
case DRMODE_SOLID|DRMODE_INT_MOD: case DRMODE_SOLID|DRMODE_INT_MOD:
bo = lcd_backdrop_offset; bo = lcd_backdrop_offset;
fg = current_vp->fg_pattern;
do do
{ {
fb_data *c = (fb_data *)((uintptr_t)dst + bo); fb_data *c = (fb_data *)((uintptr_t)dst + bo);
*dst = blend_color(*c, data & ALPHA_COLOR_LOOKUP_SIZE ); *dst = blend_two_colors(*c, fg, data & ALPHA_COLOR_LOOKUP_SIZE );
dst += COL_INC; dst += COL_INC;
UPDATE_SRC_ALPHA; UPDATE_SRC_ALPHA;
} }
@ -1074,9 +1073,10 @@ static void ICODE_ATTR lcd_alpha_bitmap_part_mix(const fb_data* image,
break; break;
case DRMODE_SOLID: case DRMODE_SOLID:
bg = current_vp->bg_pattern; bg = current_vp->bg_pattern;
fg = current_vp->fg_pattern;
do do
{ {
*dst = blend_color(bg, *dst = blend_two_colors(bg, fg,
data & ALPHA_COLOR_LOOKUP_SIZE ); data & ALPHA_COLOR_LOOKUP_SIZE );
dst += COL_INC; dst += COL_INC;
UPDATE_SRC_ALPHA; UPDATE_SRC_ALPHA;