len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-11-09 21:22:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix a bug in pcmbuf.c when doing offset with modulus.

Browse source 
Causes the track change to go in the wrong buffer (and even be missed
by playback) if the current descriptor for the write index is descriptor
0 because the offset used is "-1" upon track change.

Got nailed by implicit conversion of the % operator dividend to unsigned.

Change-Id: I32538db801ac9d790c8b1b5bd041b09ad4b64d2e
This commit is contained in:
Michael Sevakis 2013-06-28 02:17:58 -04:00
parent 363f96b95b
commit 662f7576bf
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
apps/pcmbuf.c
View file

@ -241,7 +241,7 @@ static struct chunkdesc * index_chunkdesc_offs(size_t index, int offset)
if (offset != 0) if (offset != 0)
{ {
i = (i + offset) % pcmbuf_desc_count; i = (i + offset) % (int)pcmbuf_desc_count;
/* remainder => modulus */ /* remainder => modulus */
if (i < 0) if (i < 0)