len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-12-08 12:45:26 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

rbutil: Use references to avoid creating temporary objects.

Browse source 
Get rid of some unnecessary object creating / copying by using
references.

Change-Id: Ia44e34f6f66d230caa9af7ef7c0eca73be12de2a
This commit is contained in:
Dominik Riebeling 2022-04-17 12:26:43 +02:00
parent 8c55ce62b9
commit 62108a9613
14 changed files with 24 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

4
utils/rbutilqt/test/stubs/stubs-talkgenerator.cpp
View file

@ -54,7 +54,7 @@ public:
TTSFakeEspeak(QObject *parent): TTSBase(parent) {}
virtual bool start(QString *errStr) { (void)errStr; return true; }
virtual bool stop() { return true; }
virtual TTSStatus voice(QString text, QString wavfile, QString *errStr)
virtual TTSStatus voice(const QString& text, const QString& wavfile, QString *errStr)
{ (void)text; (void)wavfile; (void)errStr; return NoError; }
virtual QString voiceVendor() { return QString("DummyVendor"); }
virtual bool configOk() { return true; }
@ -67,7 +67,7 @@ TTSBase::TTSBase(QObject* parent) : EncTtsSettingInterface(parent)
{
}
TTSStatus TTSBase::voice(QString /*text*/, QString /*wavfile*/, QString* /*errStr*/)
TTSStatus TTSBase::voice(const QString& /*text*/, const QString& /*wavfile*/, QString* /*errStr*/)
{
return NoError;
}