len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-11-10 05:32:40 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

samsungypr0/1: Minor improvements to framebuffer driver.

Browse source 
* Distinct error codes for all failures
 * Corrected some comments and error messages

The ypr0/r1 target should be switched over to the generic lcd-linuxfb
driver, but that will come later.

Change-Id: Idc3867a96db7e431847473708712f88dd2725a96
This commit is contained in:
Solomon Peachy 2024-07-01 09:40:11 -04:00
parent 311f27606c
commit 5f26f21ab2
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
firmware/target/hosted/samsungypr/lcd-ypr.c
View file

@ -66,13 +66,13 @@ void lcd_init_device(void)
exit(2); exit(2);
} }
/* Now we get the settable settings, and we set 16 bit bpp */ /* Now we get the settable settings */
if (ioctl(dev_fd, FBIOGET_VSCREENINFO, &vinfo) == -1) { if (ioctl(dev_fd, FBIOGET_VSCREENINFO, &vinfo) == -1) {
perror("Error reading variable information"); perror("Error reading variable information");
exit(3); exit(3);
} }
vinfo.bits_per_pixel = LCD_DEPTH; vinfo.bits_per_pixel = LCD_DEPTH; /* Explicitly set our desired depth */
if (ioctl(dev_fd, FBIOPUT_VSCREENINFO, &vinfo)) { if (ioctl(dev_fd, FBIOPUT_VSCREENINFO, &vinfo)) {
perror("fbset(ioctl)"); perror("fbset(ioctl)");
@ -84,17 +84,17 @@ void lcd_init_device(void)
/* Figure out the size of the screen in bytes */ /* Figure out the size of the screen in bytes */
screensize = vinfo.xres * vinfo.yres * vinfo.bits_per_pixel / 8; screensize = vinfo.xres * vinfo.yres * vinfo.bits_per_pixel / 8;
if (screensize != FRAMEBUFFER_SIZE) { if (screensize != FRAMEBUFFER_SIZE) {
exit(4);
perror("Display and framebuffer mismatch!\n"); perror("Display and framebuffer mismatch!\n");
exit(5);
} }
/* Map the device to memory */ /* Map the device to memory */
dev_fb = mmap(0, screensize, PROT_READ | PROT_WRITE, MAP_SHARED, dev_fd, 0); dev_fb = mmap(0, screensize, PROT_READ | PROT_WRITE, MAP_SHARED, dev_fd, 0);
if ((int)dev_fb == -1) { if ((int)dev_fb == -1) {
perror("Error: failed to map framebuffer device to memory"); perror("Error: failed to map framebuffer device to memory");
exit(4); exit(6);
} }
printf("The framebuffer device was mapped to memory successfully.\n"); printf("Framebuffer device successfully mapped into memory.\n");
/* Be sure to turn on display at startup */ /* Be sure to turn on display at startup */
ioctl(dev_fd, FBIOBLANK, VESA_NO_BLANKING); ioctl(dev_fd, FBIOBLANK, VESA_NO_BLANKING);