len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2026-07-10 13:29:52 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Hack to fix ipodpatcher on macOS - ignore exit code from unmount

Browse source 
ipodpatcher tries to unmount volumes that are not mounted e.g. the firmware partition, before making any changes. On macOS this fails with a non-zero exit code, causing the whole process (bootloader installation or uninstallation) to fail.

A proper fix would be to trace every path that uses ipod_reopen_rw(), and only call unmount if we expect the volume to be currently mounted.

Change-Id: Ieaa58da336216d5060465cfc2b7f5f8c729fe8b9
This commit is contained in:
Vencislav Atanasov 2026-06-19 22:02:11 +03:00 • committed by Solomon Peachy
parent a269a1360a
commit 53d2a99a2a
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
utils/ipodpatcher/ipodio-posix.c
View file

@ -338,8 +338,7 @@ int ipod_open(struct ipod_t* ipod, int silent)
int ipod_reopen_rw(struct ipod_t* ipod)
{
#if defined(__APPLE__) && defined(__MACH__)
if (ipod_unmount(ipod) < 0)
return -1;
ipod_unmount(ipod);
#endif
close(ipod->dh);