len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2026-05-12 11:43:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

playlist viewer: retrieve track name id3 from db

Browse source 
Metadata for formatting the trackname can
be read from the database instead of from
disk. I think this was changed by mistake,
when a single function was added for both
Show Track Info and track name formatting.

Change-Id: I903d36bb513898242505f01562340924bf642a12
This commit is contained in:
Christian Soffke 2026-05-11 14:49:25 +02:00 • committed by Solomon Peachy
parent 9bda6389ce
commit 51abd937d5
1 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

14
apps/playlist_viewer.c
View file

@ -52,6 +52,10 @@
#include "yesno.h" #include "yesno.h"
#include "playback.h" #include "playback.h"
#if defined (HAVE_TAGCACHE) && defined(HAVE_TC_RAMCACHE) && defined(HAVE_DIRCACHE)
#include "tagcache.h"
#endif
/* Maximum number of tracks we can have loaded at one time */ /* Maximum number of tracks we can have loaded at one time */
#define MAX_PLAYLIST_ENTRIES 200 #define MAX_PLAYLIST_ENTRIES 200
@ -285,9 +289,15 @@ static bool retrieve_id3_tags(const int index, const char* name, struct mp3entry
copy_mp3entry(id3, audio_current_track()); /* retrieve id3 from RAM */ copy_mp3entry(id3, audio_current_track()); /* retrieve id3 from RAM */
id3_retrieval_successful = true; id3_retrieval_successful = true;
} }
else #if defined (HAVE_TAGCACHE) && defined(HAVE_TC_RAMCACHE) && defined(HAVE_DIRCACHE)
else if (flags & METADATA_EXCLUDE_ID3_PATH)
/* retrieve id3 from database */
id3_retrieval_successful = tagcache_fill_tags(id3, name);
#endif
if (!id3_retrieval_successful)
{ {
/* Read from disk, the database, doesn't store frequency, file size or codec (g4470) ChrisS*/ /* Read from disk: retrieves frequency, file size, and codec */
id3_retrieval_successful = get_metadata_ex(id3, -1, name, flags); id3_retrieval_successful = get_metadata_ex(id3, -1, name, flags);
} }
return id3_retrieval_successful; return id3_retrieval_successful;