len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2026-01-22 01:30:35 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

metadata: mp3: fix iTunSMPB info replacing comment

Browse source 
Data from the iTunes seamless playback data field
(support for which was introduced in f3e5ced)
prevents proper comments from being displayed.

Change-Id: Ifb00b1229e636a79a460ba6d706191fcf28b1502
This commit is contained in:
Christian Soffke 2024-12-13 20:19:37 +01:00
parent a23002cd5e
commit 4cf65ec926
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/rbcodec/metadata/id3tags.c
View file

@ -1123,7 +1123,6 @@ retry_with_limit:
break;
tag[bytesread] = 0;
bufferpos += bytesread + 1;
/* parse the tag if it contains iTunes gapless info */
if (itunes_gapless)
@ -1131,8 +1130,11 @@ retry_with_limit:
itunes_gapless = false;
entry->lead_trim = get_itunes_int32(tag, 1);
entry->tail_trim = get_itunes_int32(tag, 2);
break;
}
bufferpos += bytesread + 1;
/* Note that parser functions sometimes set *ptag to NULL, so
* the "!*ptag" check here doesn't always have the desired
* effect. Should the parser functions (parsegenre in