len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-10-13 18:17:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

events: Rework event subsystem (add_event, send_event) to be more versatile.

Browse source 
add_event_ex is added that takes an extra user_data pointer. This pointer is
passed to the callback (add_event and add_event_ex have slightly different
callbacks types). All callbacks also get the event id passed. Events added
with add_event_ex must be removed with remove_event_ex because the user_data
pointer must match in addition to the callback pointer.

On the other add_event is simplified to omit the oneshort parameter which
was almost always false (still there with add_event_ex).

As a side effect the ata_idle_notify callbacks are changed as well, they
do not take a data parameter anymore which was always NULL anyway.

This commit also adds some documentation to events.h

Change-Id: I13e29a0f88ef908f175b376d83550f9e0231f772
This commit is contained in:
Thomas Martitz 2014-03-14 23:15:16 +01:00
parent 50f0dd80d6
commit 470989bd70
25 changed files with 247 additions and 149 deletions
Download patch file Download diff file Expand all files Collapse all files

8
apps/radio/radioart.c
View file

@ -145,7 +145,7 @@ int radio_get_art_hid(struct dim *requested_dim)
return -1;
}
static void buffer_reset_handler(void *data)
static void buffer_reset_handler(unsigned short id, void *data, void *user_data)
{
buf = NULL;
for(int i=0;i<MAX_RADIOART_IMAGES;i++)
@ -156,7 +156,9 @@ static void buffer_reset_handler(void *data)
radioart[i].name[0] = '\0';
}
(void)id;
(void)data;
(void)user_data;
}
static int shrink_callback(int handle, unsigned hints, void* start, size_t old_size)
@ -183,7 +185,7 @@ static int shrink_callback(int handle, unsigned hints, void* start, size_t old_s
buf = start;
/* one-shot */
add_event(BUFFER_EVENT_BUFFER_RESET, true, buffer_reset_handler);
add_event_ex(BUFFER_EVENT_BUFFER_RESET, true, buffer_reset_handler, NULL);
}
return BUFLIB_CB_OK;
@ -203,7 +205,7 @@ void radioart_init(bool entering_screen)
buffering_reset(core_get_data(handle), bufsize);
buf = core_get_data(handle);
/* one-shot */
add_event(BUFFER_EVENT_BUFFER_RESET, true, buffer_reset_handler);
add_event_ex(BUFFER_EVENT_BUFFER_RESET, true, buffer_reset_handler, NULL);
}
else /* init at startup */
{