len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2026-04-12 00:47:49 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

metadata: vorbis: fix warning when building sim on aarch64 linux

Browse source 
b64_codes is unsigned on some systems unless explicitly
declared as signed.

"b64_codes[index] < 0 comparison is always false due
to limited range of data type [-Werror=type-limits]"

Introduced in 849e8ab

Change-Id: I6a86e898c2ed8995f7346060f9b9b58ea6ab1e95
This commit is contained in:
Christian Soffke 2026-01-11 15:27:40 +01:00
parent 58616e685d
commit 4541c94292
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/rbcodec/metadata/vorbis.c
View file

@ -293,7 +293,7 @@ bool ogg_file_init(struct ogg_file* file, int fd, int type, int remaining)
#define B64_START_CHAR '+' #define B64_START_CHAR '+'
/* maps char codes to BASE64 codes ('A': 0, 'B': 1,... '+': 62, '-': 63 */ /* maps char codes to BASE64 codes ('A': 0, 'B': 1,... '+': 62, '-': 63 */
const char b64_codes[] = const signed char b64_codes[] =
{ /* Starts from first valid base 64 char '+' with char code 43 (B64_START_CHAR) { /* Starts from first valid base 64 char '+' with char code 43 (B64_START_CHAR)
* For valid base64 chars: index in 0..63; for invalid: -1, for =: -2 */ * For valid base64 chars: index in 0..63; for invalid: -1, for =: -2 */
62, -1, -1, -1, 63, /* 43-47 (+ /) */ 62, -1, -1, -1, 63, /* 43-47 (+ /) */