From 441fca176ab7a84da364724f38ecec1554e7c58b Mon Sep 17 00:00:00 2001 From: Michael Sevakis Date: Wed, 10 Dec 2008 21:10:34 +0000 Subject: [PATCH] Fix a wrong comment in thread.c and mention an alternative approach to inits. Fix a couple headers' Id fields while at it. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19386 a1c6a512-1295-4272-9138-f99709370657 --- apps/recorder/resize.c | 2 +- apps/recorder/resize.h | 2 +- firmware/thread.c | 6 ++++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/apps/recorder/resize.c b/apps/recorder/resize.c index 563d69f874..46c57bcb03 100644 --- a/apps/recorder/resize.c +++ b/apps/recorder/resize.c @@ -5,7 +5,7 @@ * Jukebox | | ( <_> ) \___| < | \_\ ( <_> > < < * Firmware |____|_ /\____/ \___ >__|_ \|___ /\____/__/\_ \ * \/ \/ \/ \/ \/ - * $Id + * $Id$ * * Copyright (C) 2008 by Akio Idehara, Andrew Mahone * diff --git a/apps/recorder/resize.h b/apps/recorder/resize.h index 133ac50fdd..8a39db503a 100644 --- a/apps/recorder/resize.h +++ b/apps/recorder/resize.h @@ -5,7 +5,7 @@ * Jukebox | | ( <_> ) \___| < | \_\ ( <_> > < < * Firmware |____|_ /\____/ \___ >__|_ \|___ /\____/__/\_ \ * \/ \/ \/ \/ \/ - * $Id + * $Id$ * * Copyright (C) 2008 by Akio Idehara * diff --git a/firmware/thread.c b/firmware/thread.c index 377c3355b4..2102c2f54c 100644 --- a/firmware/thread.c +++ b/firmware/thread.c @@ -3123,10 +3123,12 @@ void init_threads(void) thread->stack = stackbegin; thread->stack_size = (uintptr_t)stackend - (uintptr_t)stackbegin; #if NUM_CORES > 1 /* This code path will not be run on single core targets */ - /* Initialize all locking for the slots */ /* Wait for other processors to finish their inits since create_thread * isn't safe to call until the kernel inits are done. The first - * threads created in the system must of course be created by CPU. */ + * threads created in the system must of course be created by CPU. + * Another possible approach is to initialize all cores and slots + * for each core by CPU, let the remainder proceed in parallel and + * signal CPU when all are finished. */ core_thread_init(CPU); } else