len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-11-09 13:12:37 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

cleanup linux cpuinfo code

Browse source 
sonynwz: quirk for cpufreq broken driver

There was some redundancy between frequency_linux(cpu, true) and
current_scaling_frequency(), also I see no reason to compile the cpuinfo stuff
unconditionally and the scaling info only on DX since it was already printed
some partial scaling info anyway. Thus compile all the code unconditionally
and simplify the logic in the debug menu. Also avoid putting buffers of size
PATH_MAX on stack since it can be quite big and we only requires 64 bytes
for those paths.

On Sony NWZ, the cpu driver reports frequency in MHz instead of kHz thus we need
to make the cpuinfo code aware of that bug.

Change-Id: I61af45ab5f179ecc909b4841b9137a915a60193a
This commit is contained in:
Amaury Pouly 2017-10-06 18:31:35 +02:00
parent 2f3801be34
commit 4382f8773e
3 changed files with 27 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

8
firmware/target/hosted/cpuinfo-linux.h
View file

@ -39,9 +39,12 @@ struct time_state {
};
int cpuusage_linux(struct cpuusage* u);
int frequency_linux(int cpu, bool scaling);
/* Return the frequency of a CPU. Note that whenever CPU frequency scaling is supported by the
* driver, this frequency may not be accurate and may vaguely reflect the cpu mode. Use
* current_scaling_frequency() to get the actual frequency if scaling is supported.
* Return -1 on error. */
int frequency_linux(int cpu);
#if defined(DX50) || defined(DX90)
/*
Get the current cpufreq scaling governor.
cpu [in]: The number of the cpu to query.
@ -60,7 +63,6 @@ bool current_scaling_governor(int cpu, char* governor, int governor_size);
int min_scaling_frequency(int cpu);
int current_scaling_frequency(int cpu);
int max_scaling_frequency(int cpu);
#endif
int cpustatetimes_linux(int cpu, struct time_state* data, int max_elements);
int cpucount_linux(void);