len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-10-13 18:17:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

[Bugfix/Feature] OpenPlugin and default plugins

Browse source 
selecting files to run is nice and all but you might not like the plugin
you can edit it OpenPlugin Viewer Plugin but instead pop it when you add
a file to reduce suprises

shortcut viewer is not ready for this so exclude it for now

Change-Id: I950599d87f47d42e8c2d59695f6583d497b217f0
adds: default plugin (if any) is selected in the open with dialog
This commit is contained in:
William Wilgus 2024-05-09 15:29:54 -04:00
parent 6e82897bfc
commit 4128a1fe48
3 changed files with 52 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

6
apps/open_plugin.c
View file

@ -323,10 +323,10 @@ uint32_t open_plugin_add_path(const char *key, const char *plugin, const char *p
/* get the entry from the opx file */
op_load_entry(0, OPEN_PLUGIN_LANG_IGNORE, op_entry, plugin);
}
else if(!parameter)
else if(!parameter && lang_id != LANG_SHORTCUTS)
{
strmemccpy(op_entry->param, plugin, OPEN_PLUGIN_BUFSZ);
plugin = filetype_get_plugin(fattr, op_entry->path, OPEN_PLUGIN_BUFSZ);
plugin = filetype_get_viewer(op_entry->path, OPEN_PLUGIN_BUFSZ, plugin);
if (!plugin)
{
logf("OP no plugin found to run %s", op_entry->param);
@ -376,7 +376,7 @@ static bool callback_show_item(char *name, int attr, struct tree_context *tc)
return false;
#endif
return attr & ATTR_DIRECTORY ||
(filetype_supported(attr) && (attr & FILE_ATTR_AUDIO) == 0);
(filetype_supported(attr) && (attr & FILE_ATTR_AUDIO) != FILE_ATTR_AUDIO);
}
/* open_plugin_browse()