len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2026-07-10 13:29:52 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

bspatch: Fix compile warnings on Apple Clang 21

Browse source 
- signed/unsigned comparisons
- unambiguous fclose() result code handling

Co-authored-by: ChatGPT (GPT-5.3 Mini) <chatgpt@openai.com>
Change-Id: I6c4184ddef39281610de01b5c6ab402450d9a3ec
This commit is contained in:
Vencislav Atanasov 2026-06-29 21:30:13 +03:00
parent 9e3b38c863
commit 3d3df07c45
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
utils/bspatch/bspatch.c
View file

@ -147,8 +147,8 @@ int apply_bspatch(const char *infile, const char *outfile, const char *patchfile
pold = (u_char *)malloc(oldsize + 1);
if (pold == NULL) err(1, "Malloc failed :%s", infile);
fseek(fs, 0, SEEK_SET);
if (fread(pold, 1, oldsize, fs) == -1) err(1, "Read failed :%s", infile);
if (fclose(fs) == -1) err(1, "Close failed :%s", infile);
if (fread(pold, 1, oldsize, fs) != (size_t)oldsize) err(1, "Read failed :%s", infile);
if (fclose(fs) != 0) err(1, "Close failed :%s", infile);
pnew = malloc(newsize + 1);
if (pnew == NULL)err(1, NULL);
@ -208,8 +208,8 @@ int apply_bspatch(const char *infile, const char *outfile, const char *patchfile
/* Write the pnew file */
fs = fopen(outfile, "wb");
if (fs == NULL)err(1, "Create failed :%s", outfile);
if (fwrite(pnew, 1, newsize, fs) == -1)err(1, "Write failed :%s", outfile);
if (fclose(fs) == -1)err(1, "Close failed :%s", outfile);
if (fwrite(pnew, 1, newsize, fs) != (size_t)newsize)err(1, "Write failed :%s", outfile);
if (fclose(fs) != 0)err(1, "Close failed :%s", outfile);
free(pnew);
free(pold);