len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-11-09 13:12:37 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix FS#11387 - PictureFlow runs jerkily while playing music on Nano2G after the recent feature addition

Browse source 
The problem r26713 addressed was not caused by missing yields but by too high
priority of the background loader thread. Undoing the yield() change and decreasing
the priority fixes the audio drop as well but doesn't cause jerkiness.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30000 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Thomas Martitz 2011-06-13 16:50:10 +00:00
parent b843abef86
commit 3b18158688
1 changed files with 1 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

7
apps/plugins/pictureflow/pictureflow.c
View file

@ -1330,8 +1330,7 @@ bool create_pf_thread(void)
sizeof(thread_stack),
0,
"Picture load thread"
IF_PRIO(, MAX(PRIORITY_USER_INTERFACE / 2,
PRIORITY_REALTIME + 1))
IF_PRIO(, PRIORITY_BUFFERING)
IF_COP(, CPU)
)
) == 0) {
@ -1928,10 +1927,6 @@ void render_slide(struct slide_data *slide, const int alpha)
pixel -= PIXELSTEP_Y;
}
}
rb->yield(); /* allow audio to play when fast scrolling */
bmp = surface(slide->slide_index); /* resync surface due to yield */
src = (pix_t*)(sizeof(struct dim) + (char *)bmp);
ptr = &src[column * bmp->height];
p = (bmp->height-DISPLAY_OFFS) * PFREAL_ONE;
plim = MIN(sh * PFREAL_ONE, p + (LCD_HEIGHT/2) * dy);
int plim2 = MIN(MIN(sh + REFLECT_HEIGHT, sh * 2) * PFREAL_ONE,