len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-10-14 10:37:38 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

FS #8635 by Andree Buschmann: Fix overflow in test_disk speed calculation. No precision is lost because filesize is always a multiple of (1<<8).

Browse source 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16428 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Jens Arnold 2008-02-26 18:31:59 +00:00
parent 97d7f39680
commit 3a74611a90
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
apps/plugins/test_disk.c
View file

@ -232,7 +232,7 @@ static bool file_speed(int chunksize, bool align)
time = *rb->current_tick - time; time = *rb->current_tick - time;
rb->close(fd); rb->close(fd);
rb->snprintf(text_buf, sizeof text_buf, "Create (%d,%c): %ld KB/s", rb->snprintf(text_buf, sizeof text_buf, "Create (%d,%c): %ld KB/s",
chunksize, align ? 'A' : 'U', (25 * filesize / time) >> 8); chunksize, align ? 'A' : 'U', (25 * (filesize>>8) / time) );
log_text(text_buf, true); log_text(text_buf, true);
/* Existing file write speed */ /* Existing file write speed */
@ -255,7 +255,7 @@ static bool file_speed(int chunksize, bool align)
time = *rb->current_tick - time; time = *rb->current_tick - time;
rb->close(fd); rb->close(fd);
rb->snprintf(text_buf, sizeof text_buf, "Write (%d,%c): %ld KB/s", rb->snprintf(text_buf, sizeof text_buf, "Write (%d,%c): %ld KB/s",
chunksize, align ? 'A' : 'U', (25 * filesize / time) >> 8); chunksize, align ? 'A' : 'U', (25 * (filesize>>8) / time) );
log_text(text_buf, true); log_text(text_buf, true);
/* File read speed */ /* File read speed */
@ -278,7 +278,7 @@ static bool file_speed(int chunksize, bool align)
time = *rb->current_tick - time; time = *rb->current_tick - time;
rb->close(fd); rb->close(fd);
rb->snprintf(text_buf, sizeof text_buf, "Read (%d,%c): %ld KB/s", rb->snprintf(text_buf, sizeof text_buf, "Read (%d,%c): %ld KB/s",
chunksize, align ? 'A' : 'U', (25 * filesize / time) >> 8); chunksize, align ? 'A' : 'U', (25 * (filesize>>8) / time) );
log_text(text_buf, true); log_text(text_buf, true);
rb->remove(TEST_FILE); rb->remove(TEST_FILE);
return true; return true;