len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-11-09 13:12:37 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

quickscreen: fix EQ enable not working in quickscreen

Browse source 
The EQ enabled setting needs to call into the DSP core when it's
changed but this was only hooked into the EQ menu. The quickscreen
uses option_select_next_val() so those DSP hooks were not getting
called because the setting did not have any callback defined.

It seems this bug was introduced by 362f7a3220 removing the blanket
call to settings_apply(). Other settings might be affected too.

Change-Id: Idcce5809c525fa619e6bdf1be50c98a5df103fec
This commit is contained in:
Aidan MacDonald 2021-08-25 20:10:37 +01:00
parent b2386405b9
commit 30e96a3732
3 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
apps/settings_list.c
View file

@ -1570,7 +1570,7 @@ const struct settings_list settings[] = {
/* equalizer */
OFFON_SETTING(F_EQSETTING, eq_enabled, LANG_EQUALIZER_ENABLED, false,
"eq enabled", NULL),
"eq enabled", eq_enabled_option_callback),
INT_SETTING_NOWRAP(F_EQSETTING, eq_precut, LANG_EQUALIZER_PRECUT, 0,
"eq precut", UNIT_DB, 0, 240, 1, eq_precut_format,