len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-12-10 13:45:10 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

as3525v1: drop the asm version of mono2stereo

Browse source 
When building with eabi gcc, 2 variables are assigned the same register
This might be a bug in the constraints, but it's just simpler to use C,
even at the cost of 1 cycle per loop

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26761 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Rafaël Carré 2010-06-11 06:39:32 +00:00
parent 675dcd1a9c
commit 2f7bb96c3d
1 changed files with 1 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

15
firmware/target/arm/as3525/pcm-as3525.c
View file

@ -263,7 +263,7 @@ static inline void mono2stereo(int16_t *end)
{ {
if(audio_channels != 1) /* only for microphone */ if(audio_channels != 1) /* only for microphone */
return; return;
#if 0
/* load pointer in a register and avoid updating it in each loop */ /* load pointer in a register and avoid updating it in each loop */
register int16_t *samples = mono_samples; register int16_t *samples = mono_samples;
@ -273,19 +273,6 @@ static inline void mono2stereo(int16_t *end)
} while(samples != end); } while(samples != end);
mono_samples = samples; /* update pointer */ mono_samples = samples; /* update pointer */
#else
/* gcc doesn't use pre indexing : let's save 1 cycle */
int16_t left;
asm (
"1: ldrh %0, [%1], #2 \n" // load 1 sample of the left-channel
" strh %0, [%1], #2 \n" // copy it in the right-channel
" cmp %1, %2 \n" // are we finished?
" bne 1b \n"
: "=r"(left), "+r"(mono_samples)
: "r"(end)
: "memory"
);
#endif /* C / ASM */
} }
#endif /* CONFIG_CPU == AS3525 */ #endif /* CONFIG_CPU == AS3525 */