len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-11-09 13:12:37 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

FS#13429: Add a freeform "player name" configuration setting

Browse source 
The idea is that a theme or whatever could use this to provide visual
differentiation (eg "George's iPod") between multiple
otherwise-identical players..

Defaults to an empty string.

Added to the manual but there is not a way to set this through the
menus yet.

Change-Id: I1cff6b19d621dd6207b4b82eed67741ce2da0ef1
This commit is contained in:
Solomon Peachy 2024-05-31 10:10:45 -04:00
parent ca332b5473
commit 2bb9323de8
3 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
apps/settings.h
View file

@ -803,6 +803,7 @@ struct user_settings
#ifdef HAVE_REMOTE_LCD #ifdef HAVE_REMOTE_LCD
unsigned char remote_ui_vp_config[64]; /* viewport string for the remote lists */ unsigned char remote_ui_vp_config[64]; /* viewport string for the remote lists */
#endif #endif
char player_name[64]; /* Name of the local player */
struct compressor_settings compressor_settings; struct compressor_settings compressor_settings;

6
apps/settings_list.c
View file

@ -998,7 +998,7 @@ const struct settings_list settings[] = {
play_frequency, LANG_FREQUENCY, 0, "playback frequency", "auto", play_frequency, LANG_FREQUENCY, 0, "playback frequency", "auto",
UNIT_KHZ, formatter_freq_unit_0_is_auto, UNIT_KHZ, formatter_freq_unit_0_is_auto,
getlang_freq_unit_0_is_auto, getlang_freq_unit_0_is_auto,
playback_frequency_callback, playback_frequency_callback,
#if HAVE_PLAY_FREQ >= 192 #if HAVE_PLAY_FREQ >= 192
7,0,SAMPR_44,SAMPR_48,SAMPR_88,SAMPR_96,SAMPR_176,SAMPR_192), 7,0,SAMPR_44,SAMPR_48,SAMPR_88,SAMPR_96,SAMPR_176,SAMPR_192),
#elif HAVE_PLAY_FREQ >= 96 #elif HAVE_PLAY_FREQ >= 96
@ -1883,7 +1883,7 @@ const struct settings_list settings[] = {
#ifdef HAVE_BACKLIGHT #ifdef HAVE_BACKLIGHT
CHOICE_SETTING(0, backlight_on_button_hold, CHOICE_SETTING(0, backlight_on_button_hold,
LANG_BACKLIGHT_ON_BUTTON_HOLD, LANG_BACKLIGHT_ON_BUTTON_HOLD,
#ifdef HAS_BUTTON_HOLD #ifdef HAS_BUTTON_HOLD
1, 1,
#else #else
0, 0,
@ -2217,6 +2217,8 @@ const struct settings_list settings[] = {
VIEWPORT_SETTING(remote_ui_vp_config, "remote ui viewport"), VIEWPORT_SETTING(remote_ui_vp_config, "remote ui viewport"),
#endif #endif
TEXT_SETTING(F_THEMESETTING, player_name, "player name", "", NULL, NULL),
#ifdef HAVE_MORSE_INPUT #ifdef HAVE_MORSE_INPUT
OFFON_SETTING(0, morse_input, LANG_MORSE_INPUT, false, "morse input", NULL), OFFON_SETTING(0, morse_input, LANG_MORSE_INPUT, false, "morse input", NULL),
#endif #endif

1
manual/appendix/config_file_options.tex
View file

@ -384,6 +384,7 @@
clear settings on hold clear settings on hold
& off, on & N/A\\ & off, on & N/A\\
}% }%
player name & freeform text, defaults to an empty string & N/A\\
\bottomrule \bottomrule
\end{longtable} \end{longtable}
\end{center} \end{center}