len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2026-10-10 08:03:04 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

plugins: text_editor: fix list items that continue to scroll (FS#13900)

Browse source 
When using a theme with custom skinned lists
(e.g. Themify 2), a line in Text Editor will
continue to scroll after opening the context
menu, because you're switching from an un-
skinned list to a skinned list, which means
that list-skinned.c/list_draw isn't calling
scroll_stop_viewport for the list_text_vp,
as would be the case for un-skinned lists.

Change-Id: I952937166d8f17c9d57f4d93e715de970c49e5e8
This commit is contained in:
Christian Soffke 2026-05-19 16:57:38 +02:00
parent 1a8efac956
commit 29d62e933f
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
apps/plugins/text_editor.c
View file

@ -522,6 +522,7 @@ enum plugin_status plugin_start(const void* parameter)
case ACTION_STD_MENU: case ACTION_STD_MENU:
#endif #endif
{ {
rb->gui_synclist_scroll_stop(&lists);
/* do the item menu */ /* do the item menu */
switch (do_item_menu(cur_sel)) switch (do_item_menu(cur_sel))
{ {
@ -540,6 +541,7 @@ enum plugin_status plugin_start(const void* parameter)
case ACTION_STD_CANCEL: case ACTION_STD_CANCEL:
if (changed) if (changed)
{ {
rb->gui_synclist_scroll_stop(&lists);
MENUITEM_STRINGLIST(menu, "Text Editor", NULL, MENUITEM_STRINGLIST(menu, "Text Editor", NULL,
"Return", "Return",
"Playback Control", "Save Changes", "Playback Control", "Save Changes",