len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-11-18 01:22:38 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove the ID3 tag version priority setting on the grounds of it being pretty pointless. ID3v2 tags are superior to ID3v1 tags, and needs less seeking around to find.

Browse source 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14750 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Thom Johansen 2007-09-19 10:40:55 +00:00
parent 547cffb90b
commit 294ec1d110
19 changed files with 38 additions and 73 deletions
Download patch file Download diff file Expand all files Collapse all files

4
apps/plugins/properties.c
View file

@ -100,9 +100,9 @@ static bool file_properties(char* selected_file)
#if (CONFIG_CODEC == SWCODEC)
int fd = rb->open(selected_file, O_RDONLY);
if (fd >= 0 &&
rb->get_metadata(&id3, fd, selected_file, false))
rb->get_metadata(&id3, fd, selected_file))
#else
if (!rb->mp3info(&id3, selected_file, false))
if (!rb->mp3info(&id3, selected_file))
#endif
{
rb->snprintf(str_artist, sizeof str_artist,

3
apps/plugins/test_codec.c
View file

@ -537,8 +537,7 @@ static enum plugin_status test_track(char* filename)
/* Clear the id3 struct */
rb->memset(&track.id3, 0, sizeof(struct mp3entry));
if (!rb->get_metadata(&(track.id3), fd, filename,
rb->global_settings->id3_v1_first))
if (!rb->get_metadata(&(track.id3), fd, filename))
{
log_text("Cannot read metadata",true);
return PLUGIN_ERROR;

2
apps/plugins/vbrfix.c
View file

@ -143,7 +143,7 @@ static bool vbr_fix(char *selected_file)
xingupdate(0);
rc = rb->mp3info(&entry, selected_file, false);
rc = rb->mp3info(&entry, selected_file);
if(rc < 0) {
fileerror(rc);
return true;