len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-10-14 02:27:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

[coverity] language.c lang_load() check bytes read for headers

Browse source 
Change-Id: I546f316692c6d0c201d36d3346aab7aab6cc4919
This commit is contained in:
William Wilgus 2024-06-02 22:07:02 -04:00
parent ce6fbe4382
commit 283f31dd39
1 changed files with 9 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

13
apps/language.c
View file

@ -70,13 +70,18 @@ int lang_load(const char *filename, const unsigned char *builtin,
if(fd < 0) if(fd < 0)
return 1; return 1;
read(fd, lang_header, HEADER_SIZE);
if((lang_header[0] == LANGUAGE_COOKIE) && if(read(fd, lang_header, HEADER_SIZE) == HEADER_SIZE &&
((lang_header[0] == LANGUAGE_COOKIE) &&
(lang_header[1] == LANGUAGE_VERSION) && (lang_header[1] == LANGUAGE_VERSION) &&
(lang_header[2] == TARGET_ID)) { (lang_header[2] == TARGET_ID))) {
/* jump to the proper entry in the table of subheaders */ /* jump to the proper entry in the table of subheaders */
lseek(fd, user_num * SUBHEADER_SIZE, SEEK_CUR); lseek(fd, user_num * SUBHEADER_SIZE, SEEK_CUR);
read(fd, sub_header, SUBHEADER_SIZE); if (read(fd, sub_header, SUBHEADER_SIZE) != SUBHEADER_SIZE)
{
DEBUGF("Language %s bad subheader %u\n", filename, user_num);
retcode = 4;
}
/* read in information about the requested lang */ /* read in information about the requested lang */
#if 0 /* unused */ #if 0 /* unused */
unsigned int num_strings = (sub_header[0]<<8) | sub_header[1]; unsigned int num_strings = (sub_header[0]<<8) | sub_header[1];