len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-11-09 21:22:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove mp3info function & remove list_do_action from plugin_api

Browse source 
Change-Id: Ia9a2d6889679832f23b19a989927277ba886cba4
This commit is contained in:
Christian Soffke 2024-07-24 18:39:06 +02:00
parent 13830439fa
commit 23e5f77ab0
12 changed files with 31 additions and 57 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/rbcodec/metadata/id3tags.c
View file

@ -1200,7 +1200,7 @@ int main(int argc, char **argv)
for(i=1; i<argc; i++) {
struct mp3entry mp3;
mp3.album = "Bogus";
if(mp3info(&mp3, argv[i], false)) {
if(!get_metadata(&mp3, -1, argv[i])) {
printf("Failed to get %s\n", argv[i]);
return 0;
}

6
lib/rbcodec/metadata/metadata.c
View file

@ -399,12 +399,6 @@ unsigned int probe_file_format(const char *filename)
return AFMT_UNKNOWN;
}
/* Note, that this returns false for successful, true for error! */
bool mp3info(struct mp3entry *entry, const char *filename)
{
return !get_metadata(entry, -1, filename);
}
/* Get metadata for track - return false if parsing showed problems with the
* file that would prevent playback. supply a filedescriptor <0 and the file will be opened
* and closed automatically within the get_metadata call

1
lib/rbcodec/metadata/metadata.h
View file

@ -326,7 +326,6 @@ struct mp3entry {
unsigned int probe_file_format(const char *filename);
bool get_metadata(struct mp3entry* id3, int fd, const char* trackname);
bool get_metadata_ex(struct mp3entry* id3, int fd, const char* trackname, int flags);
bool mp3info(struct mp3entry *entry, const char *filename);
void adjust_mp3entry(struct mp3entry *entry, void *dest, const void *orig);
void copy_mp3entry(struct mp3entry *dest, const struct mp3entry *orig);
void wipe_mp3entry(struct mp3entry *id3);