len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-10-13 18:17:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

[Bugfix] WPS pause while WPS not active causes display corruption

Browse source 
Discovered this in the sim with car adapter mode: on

when charger gets disconnected the device is paused

if you have a different screen up the scrolling elems
get redrawn incorrectly over the current screen

to fix check the activity is the WPS, FM, or RECORDING  before allowing redraw

Change-Id: Ie3618347fde446fe0b78b9d3c67261ca63ffee1c
This commit is contained in:
William Wilgus 2025-02-24 09:58:28 -05:00
parent 4a6b27a712
commit 19956a0777
2 changed files with 10 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
apps/gui/wps.c
View file

@ -150,7 +150,15 @@ void wps_do_action(enum wps_do_action_type action, bool updatewps)
#endif #endif
} }
} }
if (updatewps)
/* Bugfix only do a skin refresh if in one of the below screens */
enum current_activity act = get_current_activity();
bool refresh = (act == ACTIVITY_FM ||
act == ACTIVITY_WPS ||
act == ACTIVITY_RECORDING);
if (updatewps && refresh)
update_non_static(); update_non_static();
} }

7
apps/misc.c
View file

@ -566,12 +566,7 @@ static void hp_unplug_change(bool inserted)
headphone_caused_pause && headphone_caused_pause &&
global_settings.unplug_mode > 1 ) global_settings.unplug_mode > 1 )
{ {
enum current_activity act = get_current_activity(); unpause_action(true);
/* only do a skin refresh if in one of the below screens */
bool refresh = (act == ACTIVITY_FM ||
act == ACTIVITY_WPS ||
act == ACTIVITY_RECORDING);
unpause_action(refresh);
} }
headphone_caused_pause = false; headphone_caused_pause = false;
} else { } else {