len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-10-13 18:17:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

misc: Fix up a few warnings uncovered by LTO

Browse source 
* direct use of memcpy() instead of ci->memcpy() in flac and mod
 * uninitialized variable in mpegplayer

Change-Id: I2d08682d5f66c319780e69e3ff63d600c61d8f5a
This commit is contained in:
Solomon Peachy 2021-07-08 21:08:16 -04:00
parent 4c60bc9e68
commit 144d1b1e81
4 changed files with 15 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

2
apps/plugins/mpegplayer/video_out_rockbox.c
View file

@ -369,7 +369,7 @@ void stretch_image_plane(const uint8_t * src, uint8_t *dst, int stride,
bool vo_draw_frame_thumb(uint8_t * const * buf, const struct vo_rect *rc) bool vo_draw_frame_thumb(uint8_t * const * buf, const struct vo_rect *rc)
{ {
void *mem; void *mem;
size_t bufsize; size_t bufsize = 0;
uint8_t *yuv[3]; uint8_t *yuv[3];
struct vo_rect thumb_rc; struct vo_rect thumb_rc;
int thumb_width, thumb_height; int thumb_width, thumb_height;

16
lib/rbcodec/codecs/flac.c
View file

@ -91,15 +91,15 @@ static bool flac_init(FLACContext* fc, int first_frame_offset)
nseekpoints=0; nseekpoints=0;
fc->sample_skip = 0; fc->sample_skip = 0;
/* Reset sample buffers */ /* Reset sample buffers */
memset(decoded0, 0, sizeof(decoded0)); ci->memset(decoded0, 0, sizeof(decoded0));
memset(decoded1, 0, sizeof(decoded1)); ci->memset(decoded1, 0, sizeof(decoded1));
memset(decoded2, 0, sizeof(decoded2)); ci->memset(decoded2, 0, sizeof(decoded2));
memset(decoded3, 0, sizeof(decoded3)); ci->memset(decoded3, 0, sizeof(decoded3));
memset(decoded4, 0, sizeof(decoded4)); ci->memset(decoded4, 0, sizeof(decoded4));
memset(decoded5, 0, sizeof(decoded5)); ci->memset(decoded5, 0, sizeof(decoded5));
/* Set sample buffers in decoder structure */ /* Set sample buffers in decoder structure */
fc->decoded[0] = decoded0; fc->decoded[0] = decoded0;
fc->decoded[1] = decoded1; fc->decoded[1] = decoded1;

13
lib/rbcodec/codecs/libspeex/modes_wb.c
View file

@ -1,4 +1,4 @@
/* Copyright (C) 2002-2007 Jean-Marc Valin /* Copyright (C) 2002-2007 Jean-Marc Valin
File: modes.c File: modes.c
Describes the wideband modes of the codec Describes the wideband modes of the codec
@ -6,18 +6,18 @@
Redistribution and use in source and binary forms, with or without Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions modification, are permitted provided that the following conditions
are met: are met:
- Redistributions of source code must retain the above copyright - Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer. notice, this list of conditions and the following disclaimer.
- Redistributions in binary form must reproduce the above copyright - Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution. documentation and/or other materials provided with the distribution.
- Neither the name of the Xiph.org Foundation nor the names of its - Neither the name of the Xiph.org Foundation nor the names of its
contributors may be used to endorse or promote products derived from contributors may be used to endorse or promote products derived from
this software without specific prior written permission. this software without specific prior written permission.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
@ -371,6 +371,3 @@ const SpeexMode * speex_lib_get_mode (int mode)
return speex_mode_list[mode]; return speex_mode_list[mode];
} }

2
lib/rbcodec/codecs/mod.c
View file

@ -424,7 +424,7 @@ void initmodplayer(void)
/* Set Default Panning */ /* Set Default Panning */
mixer_setpanning(c, panningvalues[c]); mixer_setpanning(c, panningvalues[c]);
/* Reset channels in the MOD Player */ /* Reset channels in the MOD Player */
memset(&modplayer.modchannel[c], 0, sizeof(struct s_modchannel)); ci->memset(&modplayer.modchannel[c], 0, sizeof(struct s_modchannel));
/* Don't play anything */ /* Don't play anything */
mixer.channel[c].channelactive = false; mixer.channel[c].channelactive = false;
} }