From 136e6b99539f11762839bf333fe3a88c04c46798 Mon Sep 17 00:00:00 2001 From: Marcin Bukat Date: Wed, 7 Oct 2026 08:20:30 +0200 Subject: [PATCH] recording: stop monitoring the input before USB mode Plugging in USB on the recording screen closes recording, but the input stays selected: the screen switches it back to playback only when it ends, which is after USB mode, at the unplug. On a Samsung YP-CP3, whose codec passes the microphone or FM radio through to the headphones while recording, the input could be heard all through USB mode. Switch to playback before entering it. Tested on a YP-CP3. Co-Authored-By: Claude Opus 5.5 Change-Id: I194d5e120cc39685aa43cea4741e826a86ed2c65 --- apps/recorder/recording.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/apps/recorder/recording.c b/apps/recorder/recording.c index 4f7ccc1be9..1a8058b089 100644 --- a/apps/recorder/recording.c +++ b/apps/recorder/recording.c @@ -1540,6 +1540,9 @@ bool recording_screen(bool no_source) { FOR_NB_SCREENS(i) screens[i].set_viewport(NULL); + /* not monitoring the input in USB mode: this screen + * only switches back to playback when it ends */ + rec_set_source(AUDIO_SRC_PLAYBACK, SRCF_PLAYBACK); default_event_handler(SYS_USB_CONNECTED); done = true; rec_status |= RCSTAT_BEEN_IN_USB_MODE;