len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2026-10-10 08:03:04 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

iap: Increase the IAP thread's stack size from 6K to 8K.

Browse source 
iAP accessories that query the track information via mode3/mode4 result
in a call to get_metatada(). This routinely overlows the current 6KB
thread stack into the iAP RX buffer, possibly corrupting the current iAP
packet being received/processed.  Bumping this to 8K should yield over
1K of headroom.

(The tagcache scanning thread uses a 16KB stack in comparison)

Inspired by commit 99b21cd6c on the rockpod fork. (Nux Li)

Change-Id: Ibe997f3ae9dab2dcc2d9947f0b49d206a5b006b6
This commit is contained in:
Solomon Peachy 2026-08-02 08:17:09 -04:00
parent 00bf7f97ba
commit 104f57252b
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
apps/iap/iap-core.c
View file

@ -96,7 +96,7 @@ int iap_repeatbtn = 0;
unsigned int iap_timeoutbtn = 0;
bool iap_btnrepeat = false, iap_btnshuffle = false;
static long thread_stack[(DEFAULT_STACK_SIZE*6)/sizeof(long)];
static long thread_stack[(DEFAULT_STACK_SIZE*8)/sizeof(long)];
static struct event_queue iap_queue;
/* These are pointer used to manage a dynamically allocated buffer which