len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-10-13 18:17:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

plugins: db_folder_select, disktidy, main_menu_config: Fix selection dialog with Show Icons set to No

Browse source 
Temporarily enable icons for required lists. Probably not a proper fix but a simple workaround.

Fixes FS#13574

Change-Id: I011a80e2a9f03019927b32e92cd5a35275c051e1
This commit is contained in:
Roman Artiukhin 2025-04-07 21:04:54 +03:00
parent b3caf32f78
commit 08bd5cdd3d
3 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
apps/plugins/db_folder_select.c
View file

@ -607,7 +607,10 @@ bool folder_select(char * header_text, char* setting, int setting_len)
info.get_name = folder_get_name; info.get_name = folder_get_name;
info.action_callback = folder_action_callback; info.action_callback = folder_action_callback;
info.get_icon = folder_get_icon; info.get_icon = folder_get_icon;
bool show_icons = rb->global_settings->show_icons;
rb->global_settings->show_icons = true;
rb->simplelist_show_list(&info); rb->simplelist_show_list(&info);
rb->global_settings->show_icons = show_icons;
logf("folder_select %d bytes free", (int)(buffer_end - buffer_front)); logf("folder_select %d bytes free", (int)(buffer_end - buffer_front));
/* done editing. check for changes */ /* done editing. check for changes */
if (hash != save_folders(root, hashed.buf, setting_len)) if (hash != save_folders(root, hashed.buf, setting_len))

3
apps/plugins/disktidy.c
View file

@ -686,7 +686,10 @@ static enum plugin_status tidy_lcd_menu(void)
list.get_icon = get_icon; list.get_icon = get_icon;
list.get_name = get_name; list.get_name = get_name;
list.action_callback = list_action_callback; list.action_callback = list_action_callback;
bool show_icons = rb->global_settings->show_icons;
rb->global_settings->show_icons = true;
rb->simplelist_show_list(&list); rb->simplelist_show_list(&list);
rb->global_settings->show_icons = show_icons;
break; break;
case 2: case 2:
disktidy_status = display_run_stats(); disktidy_status = display_run_stats();

4
apps/plugins/main_menu_config.c
View file

@ -168,6 +168,8 @@ static int menu_speak_item(int selected_item, void *data)
enum plugin_status plugin_start(const void* parameter) enum plugin_status plugin_start(const void* parameter)
{ {
(void)parameter; (void)parameter;
bool show_icons = rb->global_settings->show_icons;
rb->global_settings->show_icons = true;
struct gui_synclist list; struct gui_synclist list;
bool done = false; bool done = false;
int action, cur_sel; int action, cur_sel;
@ -241,6 +243,6 @@ enum plugin_status plugin_start(const void* parameter)
} }
} }
rb->global_settings->show_icons = show_icons;
return PLUGIN_OK; return PLUGIN_OK;
} }