len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-12-06 21:25:03 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

ipod6g: Scale CE-ATA READ/WRITE sector/counts correctly

Browse source 
Despite the fact that CE-ATA specifies a minimum logical sector size of
4096 bytes, the low-level tranfer command arguments are specified in
units of 512 bytes. So scale the sector count up and the LBA down.

On CE-ATA devies, the partition table and filesytem is formatted with 4K
logical sectors, so this will be safe.

Change-Id: I959f21f9c72a68ac28aa611d06f8517ca77f0a8c
This commit is contained in:
Solomon Peachy 2025-11-23 20:18:54 -05:00
parent e3dc4bf2d3
commit 0551c4a780
1 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
firmware/target/arm/s5l8702/ipod6g/storage_ata-6g.c
View file

@ -790,6 +790,17 @@ static void ata_power_down(void)
static int ata_rw_chunk_internal(uint64_t sector, uint32_t cnt, void* buffer, bool write) static int ata_rw_chunk_internal(uint64_t sector, uint32_t cnt, void* buffer, bool write)
{ {
if (ceata) { if (ceata) {
/* Despite the fact that CE-ATA specifies a minimum logical
sector size of 4096 bytes, the actual transfer commands
must be specified in units of 512 bytes. So scale the
sector count up and the LBA down.
On CE-ATA devies, the partition table and filesytem is
formatted with 4K logical sectors, so this will be safe.
*/
cnt <<= (identify_info[106] - 9);
sector >>= (identify_info[106] - 9);
memset(ceata_taskfile, 0, 16); memset(ceata_taskfile, 0, 16);
ceata_taskfile[0x2] = cnt >> 8; ceata_taskfile[0x2] = cnt >> 8;
ceata_taskfile[0x3] = sector >> 24; ceata_taskfile[0x3] = sector >> 24;
@ -802,7 +813,6 @@ static int ata_rw_chunk_internal(uint64_t sector, uint32_t cnt, void* buffer, bo
ceata_taskfile[0xf] = write ? CMD_WRITE_DMA_EXT : CMD_READ_DMA_EXT; ceata_taskfile[0xf] = write ? CMD_WRITE_DMA_EXT : CMD_READ_DMA_EXT;
PASS_RC(ceata_wait_idle(), 2, 0); PASS_RC(ceata_wait_idle(), 2, 0);
PASS_RC(ceata_write_multiple_register(0, ceata_taskfile, 16), 2, 1); PASS_RC(ceata_write_multiple_register(0, ceata_taskfile, 16), 2, 1);
cnt <<= (identify_info[106] - 9); /* convert LOGICAL block size into 512B CE-ATA blocks */
PASS_RC(ceata_rw_multiple_block(write, buffer, cnt, CEATA_COMMAND_TIMEOUT * HZ / 1000000), 2, 2); PASS_RC(ceata_rw_multiple_block(write, buffer, cnt, CEATA_COMMAND_TIMEOUT * HZ / 1000000), 2, 2);
return 0; return 0;
} }