len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2026-07-10 13:29:52 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

rbutilqt: Clarify if a setting comes from rbutil.ini or build-info

Browse source 
Also implement a fast path for QVariant PlayerBuildInfo::value(BuildInfo item)

Change-Id: Ice4e2dfbf9d7e3ba2e0f6692c320d50e3918b0d4
This commit is contained in:
Vencislav Atanasov 2026-06-20 18:31:51 +03:00 • committed by Solomon Peachy
parent ad64336e69
commit 005826b630
2 changed files with 16 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

18
utils/rbutilqt/base/playerbuildinfo.cpp
View file

@ -111,11 +111,6 @@ void PlayerBuildInfo::setBuildInfo(QString file)
serverInfo = new QSettings(file, QSettings::IniFormat);
}
QVariant PlayerBuildInfo::value(BuildInfo item)
{
return value(item, TypeRelease);
}
QVariant PlayerBuildInfo::value(BuildInfo item, BuildType type)
{
// locate setting item in server info file
@ -332,7 +327,7 @@ QVariant PlayerBuildInfo::value(DeviceInfo item, unsigned int match)
QVariant PlayerBuildInfo::value(SystemUrl item)
{
// locate setting item in server info file
// locate setting item in the rbutil.ini file
int i = 0;
while(PlayerSystemUrls[i].item != item)
i++;
@ -342,6 +337,17 @@ QVariant PlayerBuildInfo::value(SystemUrl item)
return result;
}
QVariant PlayerBuildInfo::value(BuildInfo item)
{
// locate setting item in the serverInfo file
int i = 0;
while(ServerInfoList[i].item != item)
i++;
QVariant result = serverInfo->value(ServerInfoList[i].name);
LOG_INFO() << "U:" << ServerInfoList[i].name << result;
return result;
}
QString PlayerBuildInfo::statusAsString(QString platform)
{

6
utils/rbutilqt/base/playerbuildinfo.h
View file

@ -106,11 +106,13 @@ public:
// Get build information for currently selected player.
QVariant value(BuildInfo item, BuildType type);
QVariant value(BuildInfo item);
// Get fixed download URL information
// Get fixed download URL information from rbutil.ini
QVariant value(SystemUrl item);
// Get fixed download URL information from serverInfo
QVariant value(BuildInfo item);
QString statusAsString(QString target = "");
protected: