len0rd/dtc
1
0
Fork 0
mirror of https://github.com/dgibson/dtc.git synced 2026-04-12 00:47:46 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Warn on node name unit-address presence/absence mismatch

Browse source 
ePAPR 1.1 section 2.2.1.1 "Node Name Requirements" specifies that any
node that has a reg property must include a unit address in its name
with value matching the first entry in its reg property. Conversely, if
a node does not have a reg property, the node name must not include a
unit address. Also allow ranges property as it is deemed valid, but ePAPR
is not clear about it.

Implement a check for this. The code doesn't validate the format of the
unit address; ePAPR implies this may vary from (containing bus) binding
to binding, so doing so would be much more complex.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
[robh: also allow non-empty ranges]
Signed-off-by: Rob Herring <robh@kernel.org>
[moved new test in check_table]
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
This commit is contained in:
Stephen Warren 2016-02-19 15:59:29 +11:00 • committed by David Gibson
parent 2e53f9d2f0
commit c9d9121683
4 changed files with 47 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tests/reg-without-unit-addr.dts Normal file
View file

@ -0,0 +1,10 @@
/dts-v1/;
/ {
#address-cells = <1>;
#size-cells = <1>;
node {
reg = <0 1>;
};
};

2
tests/run_tests.sh
View file

@ -445,6 +445,8 @@ dtc_tests () {
check_tests reg-ranges-root.dts reg_format ranges_format
check_tests default-addr-size.dts avoid_default_addr_size
check_tests obsolete-chosen-interrupt-controller.dts obsolete_chosen_interrupt_controller
check_tests reg-without-unit-addr.dts unit_address_vs_reg
check_tests unit-addr-without-reg.dts unit_address_vs_reg
run_sh_test dtc-checkfails.sh node_name_chars -- -I dtb -O dtb bad_node_char.dtb
run_sh_test dtc-checkfails.sh node_name_format -- -I dtb -O dtb bad_node_format.dtb
run_sh_test dtc-checkfails.sh prop_name_chars -- -I dtb -O dtb bad_prop_char.dtb

9
tests/unit-addr-without-reg.dts Normal file
View file

@ -0,0 +1,9 @@
/dts-v1/;
/ {
#address-cells = <1>;
#size-cells = <1>;
node@1 {
};
};