len0rd/dtc
1
0
Fork 0
mirror of https://github.com/dgibson/dtc.git synced 2026-04-11 16:37:42 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

dtc: Use a consistent type for basenamelen

Browse source 
The basenamelen member in the node structure is set in all cases to
a positive value, the length of the basename string. Also it is used as
parameters on function expecting a size_t type.

Further more an implicit cast of strspn() returned value from size_t to
int is needed in checks.c to avoid a signed/unsigned compilation warning
when this value is checked.

This member has no reason to be a signed integer and its obvious type is
size_t.

Be consistent and fix its type.

Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Message-ID: <20260210173349.636766-2-herve.codina@bootlin.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
This commit is contained in:
Herve Codina 2026-02-10 18:33:29 +01:00 • committed by David Gibson
parent 8d15a63e84
commit adba02caf5
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
checks.c
View file

@ -324,7 +324,7 @@ ERROR(node_name_chars, check_node_name_chars, NODECHARS);
static void check_node_name_chars_strict(struct check *c, struct dt_info *dti, static void check_node_name_chars_strict(struct check *c, struct dt_info *dti,
struct node *node) struct node *node)
{ {
int n = strspn(node->name, c->data); size_t n = strspn(node->name, c->data);
if (n < node->basenamelen) if (n < node->basenamelen)
FAIL(c, dti, node, "Character '%c' not recommended in node name", FAIL(c, dti, node, "Character '%c' not recommended in node name",

2
dtc.h
View file

@ -227,7 +227,7 @@ struct node {
struct node *next_sibling; struct node *next_sibling;
char *fullpath; char *fullpath;
int basenamelen; size_t basenamelen;
cell_t phandle; cell_t phandle;
int addr_cells, size_cells; int addr_cells, size_cells;