len0rd/dtc
1
0
Fork 0
mirror of https://github.com/dgibson/dtc.git synced 2025-10-13 08:17:40 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix use of <ctype.h> functions

Browse source 
The value passed to the <ctype.h> functions shall be the value of an unsigned
char or EOF.  It is implementation-defined if the char type is signed or
unsigned.  Cast to unsigned char to avoid undefined behaviour on systems where
char is signed.

This cast is already present in other parts of the code base.

Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
This commit is contained in:
Sebastian Huber 2023-07-27 13:23:28 +02:00 • committed by David Gibson
parent ccf1f62d59
commit 6df5328a90
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
checks.c
View file

@ -1182,7 +1182,7 @@ static void check_unit_address_format(struct check *c, struct dt_info *dti,
/* skip over 0x for next test */
unitname += 2;
}
if (unitname[0] == '0' && isxdigit(unitname[1]))
if (unitname[0] == '0' && isxdigit((unsigned char)unitname[1]))
FAIL(c, dti, node, "unit name should not have leading 0s");
}
WARNING(unit_address_format, check_unit_address_format, NULL,

2
yamltree.c
View file

@ -102,7 +102,7 @@ static void yaml_propval_string(yaml_emitter_t *emitter, char *str, int len)
/* Make sure the entire string is in the lower 7-bit ascii range */
for (i = 0; i < len; i++)
assert(isascii(str[i]));
assert(isascii((unsigned char)str[i]));
yaml_scalar_event_initialize(&event, NULL,
(const yaml_char_t *)YAML_STR_TAG, (const yaml_char_t*)str,