From 0d9d10184b03e352da144fb7e640016bf98fd615 Mon Sep 17 00:00:00 2001 From: David Gibson Date: Fri, 7 Dec 2007 15:37:45 +1100 Subject: [PATCH] dtc: Make dtc-checfails.sh script catch deaths-by-signal Since commit 5ba0086bfd0fa6ab25f7ce1870417301a26c104f, the dtc-checkfails.sh script does not check the return code from dtc. That's reasonable, since depending on the checks we're testing, dtc could either complete succesfully or return an error. However, it's never right for dtc to SEGV or otherwise be killed by a signal. So the script should catch that, and fail the testcase if it happens. This patch implements this behaviour. Signed-off-by: David Gibson --- tests/dtc-checkfails.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/dtc-checkfails.sh b/tests/dtc-checkfails.sh index cca4119..16a93e8 100755 --- a/tests/dtc-checkfails.sh +++ b/tests/dtc-checkfails.sh @@ -17,6 +17,10 @@ rm -f $TMPFILE $LOG verbose_run_log "$LOG" "$DTC" -o /dev/null "$@" ret="$?" +if [ "$ret" -gt 127 ]; then + FAIL "dtc killed by signal (ret=$ret)" +fi + for c in $CHECKS; do if ! grep -E "^(ERROR)|(Warning) \($c\):" $LOG > /dev/null; then FAIL "Failed to trigger check \"%c\""