From ac4313560f8d4ec4408a4c425242a4f3467b8c69 Mon Sep 17 00:00:00 2001 From: chinglee-iot <61685396+chinglee-iot@users.noreply.github.com> Date: Fri, 24 Nov 2023 14:08:34 +0800 Subject: [PATCH] Not to use object modified in the loop body (#861) Co-authored-by: Ubuntu Co-authored-by: Rahul Kar <118818625+kar-rahul-aws@users.noreply.github.com> Co-authored-by: Gaurav-Aggarwal-AWS <33462878+aggarg@users.noreply.github.com> --- tasks.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/tasks.c b/tasks.c index 7aa93f7f3..0907d35b9 100644 --- a/tasks.c +++ b/tasks.c @@ -7231,7 +7231,7 @@ static void prvResetNextTaskUnblockTime( void ) uxArraySize = uxTaskGetSystemState( pxTaskStatusArray, uxArraySize, NULL ); /* Create a human readable table from the binary data. */ - for( x = 0; ( x < uxArraySize ) && ( xOutputBufferFull == pdFALSE ); x++ ) + for( x = 0; x < uxArraySize; x++ ) { switch( pxTaskStatusArray[ x ].eCurrentState ) { @@ -7310,6 +7310,11 @@ static void prvResetNextTaskUnblockTime( void ) { xOutputBufferFull = pdTRUE; } + + if( xOutputBufferFull == pdTRUE ) + { + break; + } } /* Free the array again. NOTE! If configSUPPORT_DYNAMIC_ALLOCATION @@ -7391,7 +7396,7 @@ static void prvResetNextTaskUnblockTime( void ) if( ulTotalTime > 0UL ) { /* Create a human readable table from the binary data. */ - for( x = 0; ( x < uxArraySize ) && ( xOutputBufferFull == pdFALSE ); x++ ) + for( x = 0; x < uxArraySize; x++ ) { /* What percentage of the total run time has the task used? * This will always be rounded down to the nearest integer. @@ -7472,6 +7477,11 @@ static void prvResetNextTaskUnblockTime( void ) { xOutputBufferFull = pdTRUE; } + + if( xOutputBufferFull == pdTRUE ) + { + break; + } } } else