From 722d17b13a99f18b0bb6e6af3761ef441b1ad2cc Mon Sep 17 00:00:00 2001 From: Florian La Roche Date: Thu, 19 Jun 2025 10:32:36 +0200 Subject: [PATCH] POSIX Demo: clang warnings cleanup (#1359) Cleanup for clang compiler warnings: - add "#include" to proper header files - add "static" modifier to some vars - if tracing is disabled, do not compile helper functions - remove unused macro "mainFLASH_TASK_PRIORITY" Signed-off-by: Florian La Roche --- FreeRTOS/Demo/Posix_GCC/console.c | 6 ++++-- FreeRTOS/Demo/Posix_GCC/main.c | 5 +++++ FreeRTOS/Demo/Posix_GCC/main_full.c | 1 - 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/FreeRTOS/Demo/Posix_GCC/console.c b/FreeRTOS/Demo/Posix_GCC/console.c index fb3d869bb..31e96ead8 100644 --- a/FreeRTOS/Demo/Posix_GCC/console.c +++ b/FreeRTOS/Demo/Posix_GCC/console.c @@ -34,8 +34,10 @@ #include #include -SemaphoreHandle_t xStdioMutex; -StaticSemaphore_t xStdioMutexBuffer; +#include "console.h" + +static SemaphoreHandle_t xStdioMutex; +static StaticSemaphore_t xStdioMutexBuffer; void console_init( void ) { diff --git a/FreeRTOS/Demo/Posix_GCC/main.c b/FreeRTOS/Demo/Posix_GCC/main.c index e89da3b9e..a3d316cce 100644 --- a/FreeRTOS/Demo/Posix_GCC/main.c +++ b/FreeRTOS/Demo/Posix_GCC/main.c @@ -67,6 +67,7 @@ /* Local includes. */ #include "console.h" +#include "timers.h" #if ( projENABLE_TRACING == 1 ) #include @@ -460,6 +461,8 @@ void handle_sigint( int signal ) /*-----------------------------------------------------------*/ +#if ( projENABLE_TRACING == 1 ) + static uint32_t ulEntryTime = 0; void vTraceTimerReset( void ) @@ -481,4 +484,6 @@ uint32_t uiTraceTimerGetValue( void ) return( xTaskGetTickCount() - ulEntryTime ); } +#endif /* if ( projENABLE_TRACING == 1 ) */ + /*-----------------------------------------------------------*/ diff --git a/FreeRTOS/Demo/Posix_GCC/main_full.c b/FreeRTOS/Demo/Posix_GCC/main_full.c index a0be2b72d..8764efb47 100644 --- a/FreeRTOS/Demo/Posix_GCC/main_full.c +++ b/FreeRTOS/Demo/Posix_GCC/main_full.c @@ -114,7 +114,6 @@ #define mainSEM_TEST_PRIORITY ( tskIDLE_PRIORITY + 1 ) #define mainBLOCK_Q_PRIORITY ( tskIDLE_PRIORITY + 2 ) #define mainCREATOR_TASK_PRIORITY ( tskIDLE_PRIORITY + 3 ) -#define mainFLASH_TASK_PRIORITY ( tskIDLE_PRIORITY + 1 ) #define mainINTEGER_TASK_PRIORITY ( tskIDLE_PRIORITY ) #define mainGEN_QUEUE_TASK_PRIORITY ( tskIDLE_PRIORITY ) #define mainFLOP_TASK_PRIORITY ( tskIDLE_PRIORITY )