Code review suggestions

This commit is contained in:
Soren Ptak 2024-03-18 03:51:21 -07:00 committed by kar-rahul-aws
parent 655ba88d71
commit 3bf9afe753
14 changed files with 171 additions and 336 deletions

View file

@ -1648,12 +1648,11 @@
" push {r0} \n"
" mrs r0, control \n"
" tst r0, #1 \n"
" pop {r0} \n"
" bne MPU_xEventGroupWaitBits_Unpriv \n"
" MPU_xEventGroupWaitBits_Priv: \n"
" pop {r0} \n"
" b MPU_xEventGroupWaitBitsImpl \n"
" MPU_xEventGroupWaitBits_Unpriv: \n"
" pop {r0} \n"
" svc %0 \n"
" \n"
: : "i" ( SYSTEM_CALL_xEventGroupWaitBits ) : "memory"
@ -1679,12 +1678,11 @@
" push {r0} \n"
" mrs r0, control \n"
" tst r0, #1 \n"
" pop {r0} \n"
" bne MPU_xEventGroupClearBits_Unpriv \n"
" MPU_xEventGroupClearBits_Priv: \n"
" pop {r0} \n"
" b MPU_xEventGroupClearBitsImpl \n"
" MPU_xEventGroupClearBits_Unpriv: \n"
" pop {r0} \n"
" svc %0 \n"
" \n"
: : "i" ( SYSTEM_CALL_xEventGroupClearBits ) : "memory"
@ -1710,12 +1708,11 @@
" push {r0} \n"
" mrs r0, control \n"
" tst r0, #1 \n"
" pop {r0} \n"
" bne MPU_xEventGroupSetBits_Unpriv \n"
" MPU_xEventGroupSetBits_Priv: \n"
" pop {r0} \n"
" b MPU_xEventGroupSetBitsImpl \n"
" MPU_xEventGroupSetBits_Unpriv: \n"
" pop {r0} \n"
" svc %0 \n"
" \n"
: : "i" ( SYSTEM_CALL_xEventGroupSetBits ) : "memory"
@ -1745,12 +1742,11 @@
" push {r0} \n"
" mrs r0, control \n"
" tst r0, #1 \n"
" pop {r0} \n"
" bne MPU_xEventGroupSync_Unpriv \n"
" MPU_xEventGroupSync_Priv: \n"
" pop {r0} \n"
" b MPU_xEventGroupSyncImpl \n"
" MPU_xEventGroupSync_Unpriv: \n"
" pop {r0} \n"
" svc %0 \n"
" \n"
: : "i" ( SYSTEM_CALL_xEventGroupSync ) : "memory"
@ -1838,12 +1834,11 @@
" push {r0} \n"
" mrs r0, control \n"
" tst r0, #1 \n"
" pop {r0} \n"
" bne MPU_xStreamBufferSend_Unpriv \n"
" MPU_xStreamBufferSend_Priv: \n"
" pop {r0} \n"
" b MPU_xStreamBufferSendImpl \n"
" MPU_xStreamBufferSend_Unpriv: \n"
" pop {r0} \n"
" svc %0 \n"
" \n"
: : "i" ( SYSTEM_CALL_xStreamBufferSend ) : "memory"
@ -1873,12 +1868,11 @@
" push {r0} \n"
" mrs r0, control \n"
" tst r0, #1 \n"
" pop {r0} \n"
" bne MPU_xStreamBufferReceive_Unpriv \n"
" MPU_xStreamBufferReceive_Priv: \n"
" pop {r0} \n"
" b MPU_xStreamBufferReceiveImpl \n"
" MPU_xStreamBufferReceive_Unpriv: \n"
" pop {r0} \n"
" svc %0 \n"
" \n"
: : "i" ( SYSTEM_CALL_xStreamBufferReceive ) : "memory"
@ -1902,12 +1896,11 @@
" push {r0} \n"
" mrs r0, control \n"
" tst r0, #1 \n"
" pop {r0} \n"
" bne MPU_xStreamBufferIsFull_Unpriv \n"
" MPU_xStreamBufferIsFull_Priv: \n"
" pop {r0} \n"
" b MPU_xStreamBufferIsFullImpl \n"
" MPU_xStreamBufferIsFull_Unpriv: \n"
" pop {r0} \n"
" svc %0 \n"
" \n"
: : "i" ( SYSTEM_CALL_xStreamBufferIsFull ) : "memory"
@ -1931,12 +1924,11 @@
" push {r0} \n"
" mrs r0, control \n"
" tst r0, #1 \n"
" pop {r0} \n"
" bne MPU_xStreamBufferIsEmpty_Unpriv \n"
" MPU_xStreamBufferIsEmpty_Priv: \n"
" pop {r0} \n"
" b MPU_xStreamBufferIsEmptyImpl \n"
" MPU_xStreamBufferIsEmpty_Unpriv: \n"
" pop {r0} \n"
" svc %0 \n"
" \n"
: : "i" ( SYSTEM_CALL_xStreamBufferIsEmpty ) : "memory"
@ -1960,12 +1952,11 @@
" push {r0} \n"
" mrs r0, control \n"
" tst r0, #1 \n"
" pop {r0} \n"
" bne MPU_xStreamBufferSpacesAvailable_Unpriv \n"
" MPU_xStreamBufferSpacesAvailable_Priv: \n"
" pop {r0} \n"
" b MPU_xStreamBufferSpacesAvailableImpl \n"
" MPU_xStreamBufferSpacesAvailable_Unpriv: \n"
" pop {r0} \n"
" svc %0 \n"
" \n"
: : "i" ( SYSTEM_CALL_xStreamBufferSpacesAvailable ) : "memory"
@ -1989,12 +1980,11 @@
" push {r0} \n"
" mrs r0, control \n"
" tst r0, #1 \n"
" pop {r0} \n"
" bne MPU_xStreamBufferBytesAvailable_Unpriv \n"
" MPU_xStreamBufferBytesAvailable_Priv: \n"
" pop {r0} \n"
" b MPU_xStreamBufferBytesAvailableImpl \n"
" MPU_xStreamBufferBytesAvailable_Unpriv: \n"
" pop {r0} \n"
" svc %0 \n"
" \n"
: : "i" ( SYSTEM_CALL_xStreamBufferBytesAvailable ) : "memory"
@ -2020,12 +2010,11 @@
" push {r0} \n"
" mrs r0, control \n"
" tst r0, #1 \n"
" pop {r0} \n"
" bne MPU_xStreamBufferSetTriggerLevel_Unpriv \n"
" MPU_xStreamBufferSetTriggerLevel_Priv: \n"
" pop {r0} \n"
" b MPU_xStreamBufferSetTriggerLevelImpl \n"
" MPU_xStreamBufferSetTriggerLevel_Unpriv: \n"
" pop {r0} \n"
" svc %0 \n"
" \n"
: : "i" ( SYSTEM_CALL_xStreamBufferSetTriggerLevel ) : "memory"
@ -2049,12 +2038,11 @@
" push {r0} \n"
" mrs r0, control \n"
" tst r0, #1 \n"
" pop {r0} \n"
" bne MPU_xStreamBufferNextMessageLengthBytes_Unpriv \n"
" MPU_xStreamBufferNextMessageLengthBytes_Priv: \n"
" pop {r0} \n"
" b MPU_xStreamBufferNextMessageLengthBytesImpl \n"
" MPU_xStreamBufferNextMessageLengthBytes_Unpriv: \n"
" pop {r0} \n"
" svc %0 \n"
" \n"
: : "i" ( SYSTEM_CALL_xStreamBufferNextMessageLengthBytes ) : "memory"