len0rd/FreeRTOS-Kernel
1
0
Fork 0
mirror of https://github.com/FreeRTOS/FreeRTOS-Kernel.git synced 2025-06-05 11:59:05 -04:00
Code Issues Packages Projects Releases Wiki Activity

Update comments for the ARM_CA53_64_BIT_SRE port (#403)

Browse source 
Mention that FreeRTOS_IRQ_Handler should not be used for FIQs and the
reason for assuming Group 1 for Interrupt Acknowledge and End Of
Interrupt registers.

Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
This commit is contained in:
Gaurav-Aggarwal-AWS 2021-10-16 13:45:03 -07:00 committed by GitHub
parent 68ddb32b55
commit 06fb777e43
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
portable/GCC/ARM_CA53_64_BIT_SRE/portASM.S
View file

@ -267,6 +267,14 @@ vPortRestoreTaskContext:
/****************************************************************************** /******************************************************************************
* FreeRTOS_IRQ_Handler handles IRQ entry and exit. * FreeRTOS_IRQ_Handler handles IRQ entry and exit.
* This handler is supposed to be used only for IRQs and never for FIQs. Per ARM
* GIC documentation [1], Group 0 interrupts are always signaled as FIQs. Since
* this handler is only for IRQs, We can safely assume Group 1 while accessing
* Interrupt Acknowledge and End Of Interrupt registers and therefore, use
* ICC_IAR1_EL1 and ICC_EOIR1_EL1.
*
* [1] https://developer.arm.com/documentation/198123/0300/Arm-CoreLink-GIC-fundamentals
*****************************************************************************/ *****************************************************************************/
.align 8 .align 8
.type FreeRTOS_IRQ_Handler, %function .type FreeRTOS_IRQ_Handler, %function
@ -303,11 +311,11 @@ FreeRTOS_IRQ_Handler:
/* Maintain the interrupt nesting information across the function call. */ /* Maintain the interrupt nesting information across the function call. */
STP X1, X5, [SP, #-0x10]! STP X1, X5, [SP, #-0x10]!
/* Read value from the interrupt acknowledge register, which is stored in W0 /* Read interrupt ID from the interrupt acknowledge register and store it
for future parameter and interrupt clearing use. */ in X0 for future parameter and interrupt clearing use. */
MRS X0, S3_0_C12_C12_0 /* read ICC_IAR1_EL1 and store ICCIAR in X0 as parameter */ MRS X0, S3_0_C12_C12_0 /* S3_0_C12_C12_0 is ICC_IAR1_EL1. */
/* Maintain the ICCIAR value across the function call. */ /* Maintain the interrupt ID value across the function call. */
STP X0, X1, [SP, #-0x10]! STP X0, X1, [SP, #-0x10]!
/* Call the C handler. */ /* Call the C handler. */
@ -318,11 +326,11 @@ FreeRTOS_IRQ_Handler:
DSB SY DSB SY
ISB SY ISB SY
/* Restore the ICCIAR value. */ /* Restore the interrupt ID value. */
LDP X0, X1, [SP], #0x10 LDP X0, X1, [SP], #0x10
/* End IRQ processing by writing ICCIAR to the EOI register. */ /* End IRQ processing by writing interrupt ID value to the EOI register. */
MSR S3_0_C12_C12_1, X0 /* ICC_EOIR1_EL1 */ MSR S3_0_C12_C12_1, X0 /* S3_0_C12_C12_1 is ICC_EOIR1_EL1. */
/* Restore the critical nesting count. */ /* Restore the critical nesting count. */
LDP X1, X5, [SP], #0x10 LDP X1, X5, [SP], #0x10