devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity
foxbox/apps
History
Stéphane Doyon e5ba649d85 Fix a problem that caused stale pcm data to be played subsequent to a 
voice shutup.

Observed when moving through a few voiced items in very quick succession.

This is for the case where music playback is not in progress, only voice
is playing.  The first few samples of audio data for voicing the first
skipped item make it to the pcm buffer, but the shutup comes before
enough pcm data has accumulated to actually start pcm playback. The
condition at the top of voice_on_voice_stop() is therefore false,
pcmbuf_play_stop() is not called, and the beginning of the interrupted
utterance is left to wait in the pcm buffer. That data will end up
prepended to the following voice clip to be played, causing a kind of
stuttering effect.

The fix is to remove the condition on pcm_is_playing() in
voice_on_voice_stop(): always clear the pcm data, it's harmless if there
wasn't any.

Thanks to jhMikeS for his assistance.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15176 a1c6a512-1295-4272-9138-f99709370657
2007-10-18 00:17:15 +00:00
..
bitmaps Didn't mean to commit that change 2007-10-03 00:45:18 +00:00
codecs Make a fix for the WMA seek to start bug that actually works... 2007-10-17 18:19:35 +00:00
eqs
gui Remove the "invert scroll" code since it's not used anywhere anymore (and it was broken on color targets with gradients anyway). Closes FS #7875. 2007-10-15 20:42:51 +00:00
keymaps Enable recording for Sansa c200, the keymap is usable but maybe could still be improved later. 2007-10-10 22:49:39 +00:00
lang Updated italian translation. 2007-10-16 20:39:14 +00:00
menus Voice the recording trigger settings screen. 2007-10-10 01:41:48 +00:00
metadata Fix FS #7976. WMA metadata parser didn't store file size in metadata struct. 2007-10-16 20:21:02 +00:00
player Slight code policing. 2007-10-10 06:02:08 +00:00
plugins Less stack hogging in the coldfire IDCT for mpegplayer. Speedup might or might not be measurable. 2007-10-18 00:14:22 +00:00
recorder Disable highperf mode in the peakmeter for swcodec targets, as it makes no sense. Improves responsiveness a lot with a peakmeter-enabled wps on targets with slow lcd updates (e.g. G5). Added a comment why highperf mode is needed for MAS targets. 2007-10-16 08:34:51 +00:00
abrepeat.c
abrepeat.h
action.c *** Lang v2 cleanup (FS#6574) *** 2007-08-05 19:19:39 +00:00
action.h Finally use the rec button to get to the rec screen on sansa and iriver hxxx. hold rec to get there... short press still is unused 2007-08-02 12:13:20 +00:00
alarm_menu.c FS#7682 by Daniel Dalton - Enable voice in the wakeup alarm screen 2007-10-04 08:56:49 +00:00
alarm_menu.h
applimits.h
audio_path.c Straighten out some audio path APIs and misc. audio stuff. Having recording is not a prerequisite to having input/output source selection which is probably most useful when adding a audio input features like FM to a new port without forcing recording to be implemented first. 2007-06-08 23:42:04 +00:00
bookmark.c minor update to gui_synclist_do_button() which will hopefully simplify things later. 2007-09-17 10:08:50 +00:00
bookmark.h
codecs.c Commit a subset of the dual core changes that have to do with cache handling, stacks, firmware startup and thread startup. Tested on e200, H10-20GB, iPod Color and 5.5G. Thread function return implemented for all targets. Some changes to plugins to follow shortly. 2007-09-28 10:20:02 +00:00
codecs.h Hide symbols by default on 64 bit sim buildsto avoid clashing, fixes crashing on track change with the same codec, crashing in calculator and text display in midiplay 2007-10-02 09:08:08 +00:00
cuesheet.c minor update to gui_synclist_do_button() which will hopefully simplify things later. 2007-09-17 10:08:50 +00:00
cuesheet.h Set properties for the files I added. 2007-07-26 14:23:08 +00:00
debug_menu.c Finally full multicore support for PortalPlayer 502x targets with an eye towards the possibility of other types. All SVN targets the low-lag code to speed up blocking operations. Most files are modified here simple due to a name change to actually support a real event object and a param change to create_thread. Add some use of new features but just sit on things for a bit and leave full integration for later. Work will continue on to address size on sensitive targets and simplify things if possible. Any PP target having problems with SWP can easily be changed to sw corelocks with one #define change in config.h though only PP5020 has shown an issue and seems to work without any difficulties. 2007-10-16 01:25:17 +00:00
debug_menu.h
dsp.c FS #7286. Do correct rounding of final 16 bit samples before sending to DAC, for you golden-eared people. 2007-08-29 14:32:52 +00:00
dsp.h Code cleaning - remove some unnecessary defined(SIMULATOR) checks 2007-05-10 13:16:08 +00:00
dsp_arm.S ARM assembler for resampling. Should provide some gains, though not huge ones. 2007-03-11 23:33:58 +00:00
dsp_asm.h Code cleaning - remove some unnecessary defined(SIMULATOR) checks 2007-05-10 13:16:08 +00:00
dsp_cf.S FS #7286. Do correct rounding of final 16 bit samples before sending to DAC, for you golden-eared people. 2007-08-29 14:32:52 +00:00
enc_config.c Assumption about there being MPEG1-only samplerates available and therefore MPEG1-only bitrates for recording is no longer valid. Fix that. 2007-06-06 21:24:20 +00:00
enc_config.h
eq.c Code cleaning - remove some unnecessary defined(SIMULATOR) checks 2007-05-10 13:16:08 +00:00
eq.h Factor first order shelving filter code out for easier reuse and replace the crossfeed filter with it. Crossfeed _should_ still sound the same, so please do tell if it doesn't. 2007-03-07 15:06:33 +00:00
eq_arm.S iPod 1st..3rd Gen: Nearly halve the cost of software treble/bass (and eq) by putting the filter routine in IRAM. 2007-08-24 21:03:19 +00:00
eq_cf.S
features.txt fix lang problem and little clean up 2007-08-27 17:45:01 +00:00
FILES Add Makefile to FILES and fix comment. 2007-09-27 04:46:53 +00:00
filetree.c Accept FS#6159 'Add voice to roughly 100 splash screens and yes-no menus' by Stephane Doyon with some minor tweaks by me. Rerun 'configure' and do a 'make clean' before rebuilding your voice files. 2007-08-06 13:08:36 +00:00
filetree.h #ifdef code that only makes sense for multivolume targets, make private functions 'static' 2007-03-17 00:55:23 +00:00
filetypes.c minor update to gui_synclist_do_button() which will hopefully simplify things later. 2007-09-17 10:08:50 +00:00
filetypes.h Fix some bugs with the colors stuff. You can now specify folder color with the folder extension. 2007-06-17 23:10:01 +00:00
keyboard.h
language.c *** Lang v2 cleanup (FS#6574) *** 2007-08-05 19:19:39 +00:00
language.h *** Lang v2 cleanup (FS#6574) *** 2007-08-05 19:19:39 +00:00
logfdisp.c Make logf builds compile again since the clean up of hard-coded paths 2007-09-10 19:29:53 +00:00
logfdisp.h
main.c Unify PCM interface just above the hardware driver level for all targets including the sims. Perform lockout of audio callback when changing states. Weird new playback or recording trouble? Check before and after this revision first though things seem quite sound. 2007-10-06 22:27:27 +00:00
Makefile Make sure that the apps directory exists when building the apps/features file 2007-09-11 07:43:33 +00:00
menu.c Add a voice callback to dynamic menus, along side the text_callback. 2007-10-09 03:48:56 +00:00
menu.h Add a voice callback to dynamic menus, along side the text_callback. 2007-10-09 03:48:56 +00:00
metadata.c get_metadata(): Clear the destination mp3entry to avoid having bogus pointers appear in it. 2007-10-05 16:02:35 +00:00
metadata.h Remove the ID3 tag version priority setting on the grounds of it being pretty pointless. ID3v2 tags are superior to ID3v1 tags, and needs less seeking around to find. 2007-09-19 10:40:55 +00:00
misc.c Make sure that audio_resume() is not called in interrupt context when car adapter mode is enabled. Fixes FS#7304. 2007-10-08 09:09:40 +00:00
misc.h Fix some places for USB_NONE. Still some more complex cases left though. 2007-08-01 20:21:34 +00:00
onplay.c Add a voice callback to dynamic menus, along side the text_callback. 2007-10-09 03:48:56 +00:00
onplay.h
pcmbuf.c Unify PCM interface just above the hardware driver level for all targets including the sims. Perform lockout of audio callback when changing states. Weird new playback or recording trouble? Check before and after this revision first though things seem quite sound. 2007-10-06 22:27:27 +00:00
pcmbuf.h Code cleaning - remove some unnecessary defined(SIMULATOR) checks 2007-05-10 13:16:08 +00:00
playback.c Fix a problem that caused stale pcm data to be played subsequent to a 2007-10-18 00:17:15 +00:00
playback.h Thanks to Nico_P, struct track_info can now be internal to playback.c 2007-10-02 07:47:43 +00:00
playlist.c Finally full multicore support for PortalPlayer 502x targets with an eye towards the possibility of other types. All SVN targets the low-lag code to speed up blocking operations. Most files are modified here simple due to a name change to actually support a real event object and a param change to create_thread. Add some use of new features but just sit on things for a bit and leave full integration for later. Work will continue on to address size on sensitive targets and simplify things if possible. Any PP target having problems with SWP can easily be changed to sw corelocks with one #define change in config.h though only PP5020 has shown an issue and seems to work without any difficulties. 2007-10-16 01:25:17 +00:00
playlist.h
playlist_catalog.c minor update to gui_synclist_do_button() which will hopefully simplify things later. 2007-09-17 10:08:50 +00:00
playlist_catalog.h
playlist_menu.h More header and dead code cleanup. 2007-05-19 20:55:49 +00:00
playlist_viewer.c Playlist viewer move live preview. Closes FS #7968. 2007-10-15 20:34:02 +00:00
playlist_viewer.h
plugin.c Finally full multicore support for PortalPlayer 502x targets with an eye towards the possibility of other types. All SVN targets the low-lag code to speed up blocking operations. Most files are modified here simple due to a name change to actually support a real event object and a param change to create_thread. Add some use of new features but just sit on things for a bit and leave full integration for later. Work will continue on to address size on sensitive targets and simplify things if possible. Any PP target having problems with SWP can easily be changed to sw corelocks with one #define change in config.h though only PP5020 has shown an issue and seems to work without any difficulties. 2007-10-16 01:25:17 +00:00
plugin.h Finally full multicore support for PortalPlayer 502x targets with an eye towards the possibility of other types. All SVN targets the low-lag code to speed up blocking operations. Most files are modified here simple due to a name change to actually support a real event object and a param change to create_thread. Add some use of new features but just sit on things for a bit and leave full integration for later. Work will continue on to address size on sensitive targets and simplify things if possible. Any PP target having problems with SWP can easily be changed to sw corelocks with one #define change in config.h though only PP5020 has shown an issue and seems to work without any difficulties. 2007-10-16 01:25:17 +00:00
README
root_menu.c Fix a bug whereby ACTION_TREE_WPS (GO_TO_PREVIOUS_MUSIC) brings us to the 2007-10-12 04:20:20 +00:00
root_menu.h Fix a bug whereby ACTION_TREE_WPS (GO_TO_PREVIOUS_MUSIC) brings us to the 2007-10-12 04:20:20 +00:00
screen_access.c Remove the "invert scroll" code since it's not used anywhere anymore (and it was broken on color targets with gradients anyway). Closes FS #7875. 2007-10-15 20:42:51 +00:00
screen_access.h Remove the "invert scroll" code since it's not used anywhere anymore (and it was broken on color targets with gradients anyway). Closes FS #7875. 2007-10-15 20:42:51 +00:00
screens.c Finally full multicore support for PortalPlayer 502x targets with an eye towards the possibility of other types. All SVN targets the low-lag code to speed up blocking operations. Most files are modified here simple due to a name change to actually support a real event object and a param change to create_thread. Add some use of new features but just sit on things for a bit and leave full integration for later. Work will continue on to address size on sensitive targets and simplify things if possible. Any PP target having problems with SWP can easily be changed to sw corelocks with one #define change in config.h though only PP5020 has shown an issue and seems to work without any difficulties. 2007-10-16 01:25:17 +00:00
screens.h ifdef out charging screen for targets that do not use it, + minor cleaning 2007-07-08 15:32:56 +00:00
scrobbler.c A patch by Robert Keevil that's been in the tracker way to long, fixes FS #6213: Audioscrobbler incorrectly submits last song 2007-06-24 18:46:04 +00:00
scrobbler.h A patch by Robert Keevil that's been in the tracker way to long, fixes FS #6213: Audioscrobbler incorrectly submits last song 2007-06-24 18:46:04 +00:00
settings.c Name all button light functions and variables consistently starting with buttonlight_ . 2007-10-07 15:02:02 +00:00
settings.h Voice the recording trigger settings screen. 2007-10-10 01:41:48 +00:00
settings_list.c Allow people to waste lots of memory and have 32000 tracks in a single playlist, should they so desire. 2007-10-16 14:01:56 +00:00
settings_list.h Integer setting changes to make all those settings consistant on the target. 2007-10-15 10:33:01 +00:00
sound_menu.h More header and dead code cleanup. 2007-05-19 20:55:49 +00:00
SOURCES Accept FS#7864 - minor menu cleanup to move theme settings into a new themes menu. patch to update the manual would be welcome :p 2007-10-06 11:47:41 +00:00
status.c Set CONFIG_RTC to 0 for non-RTC targets, and check with #if to profit from -Wundef. No code change. 2007-03-16 23:47:03 +00:00
status.h
tagcache.c Take out some NOCACHEBSS_ATTR's that were accidentally left. Put some threading code in IRAM that should be there on PP502x. 2007-10-16 22:00:51 +00:00
tagcache.h Add support for grouping tags. From FS#7362. 2007-08-08 10:19:56 +00:00
tagnavi.config Get rid of special handling of 'The'; it's 100% language-specific and we need to work towards better handling og 'The' in general. Feel free to include it in your own tagnavi_custom.config if you really need it. 2007-10-17 13:53:48 +00:00
tagtree.c Add support for grouping tags. From FS#7362. 2007-08-08 10:19:56 +00:00
tagtree.h FS#7003 - Allow forward references of menus in tagnavi.config. 2007-06-22 12:48:06 +00:00
talk.c Export shutup() function from talk.c. 2007-10-10 03:12:17 +00:00
talk.h Export shutup() function from talk.c. 2007-10-10 03:12:17 +00:00
tree.c Don't get the dircache size while dircache is still initializing. If done during shutdown, it will force a foreground scan on next boot. 2007-10-07 12:05:48 +00:00
tree.h Accept FS#7486 - shortcuts plugin. 2007-08-05 12:14:07 +00:00
version.h

README 

For general information see: docs/README
For API information see: docs/API