devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity
foxbox/apps/gui
History
Christian Soffke 2b30a9fed8 sb_create_from_settings: Fix crash when ui viewport setting malformed 
The 'Purple_Glow_V3' theme uses the following
'UI viewport' setting which is missing a comma
after the viewport height:

ui viewport: 0,0,271,212-,-,-

The setting is actually ignored when loading this theme,
since a UI viewport is already defined in the supplied
SBS file.

Rockbox will crash, though, when and if the next theme
that is loaded resets the SBS by setting it to "-", but
doesn't adjust the UI viewport setting at the same time.

To fix, use default UI viewport when encountering fewer
parameters than expected for the UI viewport setting.

Change-Id: I2648565ac59369ce8ab18d8e84b7fa69ad767f25
2025-03-25 00:02:43 -04:00
..
bitmap Allow scroll_all lists to resume scrolling lines 2024-12-17 23:51:21 -05:00
skin_engine checkwps: Warn if using SYSFONT in a viewport 2025-03-07 09:39:53 -05:00
backdrop.c
backdrop.h
color_picker.c screen_access add set_drawinfo 2025-02-08 00:49:28 -05:00
color_picker.h color_picker: a bit of rework for color_picker. 2010-02-11 14:18:31 +00:00
folder_select.c [coverity] folder_select.c find_from_filename() guard against NULL 2024-06-05 23:38:25 -04:00
folder_select.h New GUI browser to select one (or more) folders. 2012-07-30 21:20:51 +02:00
icon.c gui: Fix unsuccesful attempt at loading default viewer iconset 2024-11-16 12:14:00 -05:00
icon.h [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
line.c screen_access add set_drawinfo 2025-02-08 00:49:28 -05:00
line.h lcd-24bit: Introduce a 24-bit mid-level LCD driver 2014-06-21 00:15:53 +02:00
list.c [Bugfix] Simulator doesn't scroll lists in plugins 2024-12-16 11:37:56 -05:00
list.h Simplelist remove simplelist_set_line_count(n) 2024-11-21 12:14:17 -05:00
mask_select.c mask_select guard against null pointers 2021-08-03 11:00:59 +00:00
mask_select.h Selective Backlight/Advanced Softlock - Selective actions based on context 2017-01-17 23:06:17 +01:00
option_select.c Move cfg_vals from settings_list, expand settings_dumper 2024-11-10 21:53:22 -05:00
option_select.h Move cfg_vals from settings_list, expand settings_dumper 2024-11-10 21:53:22 -05:00
pitchscreen.c [Feature] Persist pitch settings through reboots part deux 2025-01-19 00:29:47 -05:00
pitchscreen.h [Feature] Persist pitch settings through reboots part deux 2025-01-19 00:29:47 -05:00
quickscreen.c [Bugfix] shuffle shenanigans from g5288 Fix #13369 shuffle & repeat callbacks 2023-08-29 01:29:38 -04:00
quickscreen.h quickscreen: Settings ID to pointer conversion 2022-12-17 13:36:38 +00:00
scrollbar.c [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
scrollbar.h [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
splash.c make splash_progress lock to screen width on repeated calls 2025-02-28 12:09:55 -05:00
splash.h splash_progress add delay function 2022-10-13 00:10:25 -04:00
statusbar-skinned.c sb_create_from_settings: Fix crash when ui viewport setting malformed 2025-03-25 00:02:43 -04:00
statusbar-skinned.h skin_engine minor refactoring struct alignment No Functional Changes 2024-12-03 01:21:28 -05:00
statusbar.c [BugFix] itoa conflicts with mingw rename to itoa_buf 2025-02-18 10:41:18 -05:00
statusbar.h Small cleanup statusbar 2025-01-17 00:08:28 -05:00
usb_screen.c [Bugfix] FS#12436 cache mode strings prior to font disable 2025-03-11 11:41:17 -04:00
usb_screen.h Fix warning on USB_NONE targets 2010-10-14 12:29:19 +00:00
viewport.c Revert "Eliminate SBS update on WPS exit" 2025-03-23 05:15:44 +01:00
viewport.h Remove get_viewport_default_colour() 2022-11-17 16:12:19 +00:00
wps.c Revert "Eliminate SBS update on WPS exit" 2025-03-23 05:15:44 +01:00
wps.h [FixRed] checkwps has no concept of playback 2024-12-11 01:23:54 -05:00
yesno.c [BugFix] YesNo screen wait for button release on exit 2025-01-17 00:42:25 -05:00
yesno.h [Feature] add a prompt to database commit on start-up 2023-10-01 11:51:38 -04:00