forked from len0rd/rockbox
Fork of rockbox tailored for ipod classic
58462184d1
| with some code refactoring we can eliminate the static char buffer in get_full_path() I'm guessing making the functions recursive prompted the static buffer I don't see any reason we can't just pass the same buffer | During tested I noted failure after buffer was full -- splash added for buffer full notification added some logic to not add partial entries and try to find a | selected item that will fit in the remaing buffer ------------------------------------------------------------------------ While looking through the source I noticed a few potential pitfalls with the current code. Namely the stack allocated temporary buffer sized to setting_len. I also noted the rigid vect[32] with the timeless -- /* 32 separate folders should be Enough For Everybody(TM) */ and decided to make it a bit more robust The saved items are hashed with crc32 on all the paths and a hashed_len is kept to aid in the buffer full message before the user actually goes to save the changes (assuming they even get the message) In the old code, buffer might be the same since it ran out of space and didn't get their later selections the hashed_len could easily be turned into a way to get a needed buffer size as well for someone in the future just pass a really large maxlen I made get_full_path non recursive since it liked to blow the stack while embedded in all the other recursive calls making it a pain to debug (the real reason the buffer was static?) traverse first from the current folder to root mutating the parent pointers to point at the previous child next traverse back to the folder unmutating & taking names on the way Folder depth is now uint16 65535 levels is probably excessive children_count is also uint16 as well I made the first folders below root '/' stay below root instead of shifting since the horizontal real estate is limited slightly smaller than it began but hopefully faster & more reliable Change-Id: I348f61baf865cccdeacddfd9d50641a882e890fc |
||
|---|---|---|
| android | ||
| apps | ||
| backdrops | ||
| bootloader | ||
| debian | ||
| docs | ||
| firmware | ||
| fonts | ||
| gdb | ||
| icons | ||
| lib | ||
| manual | ||
| packaging | ||
| rbutil | ||
| tools | ||
| uisimulator | ||
| utils | ||
| wps | ||
| .gitattributes | ||
| .gitignore | ||
| .gitreview | ||
__________ __ ___.
Open \______ \ ____ ____ | | _\_ |__ _______ ___
Source | _// _ \_/ ___\| |/ /| __ \ / _ \ \/ /
Jukebox | | ( <_> ) \___| < | \_\ ( <_> > < <
Firmware |____|_ /\____/ \___ >__|_ \|___ /\____/__/\_ \
\/ \/ \/ \/ \/
Build Your Own Rockbox
1. Clone 'rockbox' from git (or extract a downloaded archive).
$ git clone git://git.rockbox.org/rockbox
or
$ tar xjf rockbox.tar.bz2
2. Create a build directory, preferably in the same directory as the firmware/
and apps/ directories. This is where all generated files will be written.
$ cd rockbox
$ mkdir build
$ cd build
3. Make sure you have mips/m68k/arm-elf-gcc and siblings in the PATH. Make sure
that you have 'perl' in your PATH too. Your gcc cross compiler needs to be
a particular version depending on what player you are compiling for. These
can be generated using the rockboxdev.sh script in the /tools/ folder of the
source.
$ which arm-elf-eabi-gcc
$ which perl
4. In your build directory, run the 'tools/configure' script and enter what
target you want to build for and if you want a debug version or not (and a
few more questions). It'll prompt you. The debug version is for making a
gdb version out of it. It is only useful if you run gdb towards your target
Archos.
$ ../tools/configure
5. *ploink*. Now you have got a Makefile generated for you.
6. Run 'make' and soon the necessary pieces from the firmware and the apps
directories have been compiled, linked and scrambled for you.
$ make
$ make zip
7. unzip the rockbox.zip on your music player, reboot it and
*smile*.
If you want to build for more than one target, just create several build
directories and create a setup for each target:
$ mkdir build-fuzeplus
$ cd build-fuzeplus
$ ../tools/configure
$ mkdir build-xduoox3
$ cd build-xduoox3
$ ../tools/configure
Questions anyone? Ask on the mailing list or on IRC. We'll be happy to help you!