1
0
Fork 0
forked from len0rd/rockbox
foxbox/apps/gui/skin_engine
William Wilgus 79bed1f422 RFC skin_tokens remove a static buffer
it was hard to hit this branch, I had to comment out:
ln 555    else if (offset == 1)
ln 556        pid3 = state->nid3;

as far as I can tell the reason for the separate filename buffer
was due to the failure mode of audio_peek_track() wiping
the id3->path, stands to reason for me that we can just fill it
again

-Already found a gotcha playlist_peek() mutates the buffer
 makes me like this solution less, might rework tagcache_fill_tags()
instead

--Fixed

Change-Id: I4a2ee71a8e2d0739c9e141948b71c2ed36296e3b
2024-09-12 19:16:02 -04:00
..
skin_backdrops.c Remove buflib allocation names, part two 2023-01-13 10:32:54 +00:00
skin_display.c RFC: Extend skin engine to handle EQ settings 2024-04-21 18:27:11 -04:00
skin_display.h skin engine: Remove progressbar viewport field 2022-11-23 09:44:23 -05:00
skin_engine.c Move skin global state to the WPS 2022-10-18 12:56:28 +01:00
skin_engine.h skin engine: Reduce scope of internal wps_data struct 2022-11-15 14:20:31 +00:00
skin_parser.c [coverity] skin_parser.c load_skin_bitmaps check buffer length for bm_data 2024-06-02 11:13:03 -04:00
skin_render.c skin engine: Remove viewport_colour viewport field 2022-11-23 10:06:16 -05:00
skin_tokens.c RFC skin_tokens remove a static buffer 2024-09-12 19:16:02 -04:00
skin_touchsupport.c RFC: Extend skin engine to handle EQ settings 2024-04-21 18:27:11 -04:00
wps_internals.h checkwps: Validate translated strings (%Sx) 2024-05-24 21:37:54 -04:00